Skip to content

Commit

Permalink
nfs: remove redundant call to nfs_context_set_write_error()
Browse files Browse the repository at this point in the history
We don't need to call this in the direct, read, or pnfs resend paths and
the only other caller is the write path in nfs_page_async_flush() which
already checks and sets the pg_error on the context.

Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
  • Loading branch information
Benjamin Coddington authored and Trond Myklebust committed Oct 18, 2018
1 parent fdbd1a2 commit fc18751
Showing 1 changed file with 0 additions and 4 deletions.
4 changes: 0 additions & 4 deletions fs/nfs/pagelist.c
Original file line number Diff line number Diff line change
Expand Up @@ -1174,10 +1174,6 @@ int nfs_pageio_add_request(struct nfs_pageio_descriptor *desc,
return 1;

out_failed:
/* remember fatal errors */
if (nfs_error_is_fatal(desc->pg_error))
nfs_context_set_write_error(req->wb_context,
desc->pg_error);
nfs_pageio_error_cleanup(desc);
return 0;
}
Expand Down

0 comments on commit fc18751

Please sign in to comment.