Skip to content

Commit

Permalink
staging: mt7621-pci-phy: use 'platform_get_resource'
Browse files Browse the repository at this point in the history
Driver is using 'of_address_to_resource' to get memory resources.
Make use of 'platform_get_resource' instead which is more accurate
for a platform driver. This also makes possible to delete a local
variable which is not needed anymore.

Signed-off-by: Sergio Paracuellos <sergio.paracuellos@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Sergio Paracuellos authored and Greg Kroah-Hartman committed Apr 19, 2019
1 parent 9c5d9e5 commit fc1e669
Showing 1 changed file with 5 additions and 6 deletions.
11 changes: 5 additions & 6 deletions drivers/staging/mt7621-pci-phy/pci-mt7621-phy.c
Original file line number Diff line number Diff line change
Expand Up @@ -308,11 +308,10 @@ static struct phy *mt7621_pcie_phy_of_xlate(struct device *dev,
static int mt7621_pci_phy_probe(struct platform_device *pdev)
{
struct device *dev = &pdev->dev;
struct device_node *np = dev->of_node;
struct device_node *child_np;
struct phy_provider *provider;
struct mt7621_pci_phy *phy;
struct resource res;
struct resource *res;
int port, ret;
void __iomem *port_base;

Expand All @@ -329,13 +328,13 @@ static int mt7621_pci_phy_probe(struct platform_device *pdev)
phy->dev = dev;
platform_set_drvdata(pdev, phy);

ret = of_address_to_resource(np, 0, &res);
if (ret) {
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
if (!res) {
dev_err(dev, "failed to get address resource\n");
return ret;
return -ENXIO;
}

port_base = devm_ioremap_resource(dev, &res);
port_base = devm_ioremap_resource(dev, res);
if (IS_ERR(port_base)) {
dev_err(dev, "failed to remap phy regs\n");
return PTR_ERR(port_base);
Expand Down

0 comments on commit fc1e669

Please sign in to comment.