Skip to content

Commit

Permalink
hinic: fix sending pkts from core while self testing
Browse files Browse the repository at this point in the history
Call netif_tx_disable firstly before starting doing self-test to
avoid sending packet from networking core and self-test packet
simultaneously which may cause self-test failure or hw abnormal.

Fixes: 4aa218a ("hinic: add self test support")
Signed-off-by: Luo bin <luobin9@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Luo bin authored and David S. Miller committed Sep 18, 2020
1 parent 2b33b20 commit fc25fa9
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 2 deletions.
4 changes: 4 additions & 0 deletions drivers/net/ethernet/huawei/hinic/hinic_ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -1654,6 +1654,7 @@ static void hinic_diag_test(struct net_device *netdev,
}

netif_carrier_off(netdev);
netif_tx_disable(netdev);

err = do_lp_test(nic_dev, eth_test->flags, LP_DEFAULT_TIME,
&test_index);
Expand All @@ -1662,9 +1663,12 @@ static void hinic_diag_test(struct net_device *netdev,
data[test_index] = 1;
}

netif_tx_wake_all_queues(netdev);

err = hinic_port_link_state(nic_dev, &link_state);
if (!err && link_state == HINIC_LINK_STATE_UP)
netif_carrier_on(netdev);

}

static int hinic_set_phys_id(struct net_device *netdev,
Expand Down
4 changes: 2 additions & 2 deletions drivers/net/ethernet/huawei/hinic/hinic_tx.c
Original file line number Diff line number Diff line change
Expand Up @@ -717,8 +717,8 @@ static int free_tx_poll(struct napi_struct *napi, int budget)
netdev_txq = netdev_get_tx_queue(txq->netdev, qp->q_id);

__netif_tx_lock(netdev_txq, smp_processor_id());

netif_wake_subqueue(nic_dev->netdev, qp->q_id);
if (!netif_testing(nic_dev->netdev))
netif_wake_subqueue(nic_dev->netdev, qp->q_id);

__netif_tx_unlock(netdev_txq);

Expand Down

0 comments on commit fc25fa9

Please sign in to comment.