Skip to content

Commit

Permalink
net: amd: replace dev_kfree_skb_irq by dev_consume_skb_irq for drop p…
Browse files Browse the repository at this point in the history
…rofiles

dev_consume_skb_irq() should be called when skb xmit done. It makes
drop profiles(dropwatch, perf) more friendly.

Signed-off-by: Yang Wei <yang.wei9@zte.com.cn>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Yang Wei authored and David S. Miller committed Feb 14, 2019
1 parent 76cba8f commit fc67ade
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion drivers/net/ethernet/amd/lance.c
Original file line number Diff line number Diff line change
@@ -1084,7 +1084,7 @@ static irqreturn_t lance_interrupt(int irq, void *dev_id)
/* We must free the original skb if it's not a data-only copy
in the bounce buffer. */
if (lp->tx_skbuff[entry]) {
dev_kfree_skb_irq(lp->tx_skbuff[entry]);
dev_consume_skb_irq(lp->tx_skbuff[entry]);
lp->tx_skbuff[entry] = NULL;
}
dirty_tx++;
2 changes: 1 addition & 1 deletion drivers/net/ethernet/amd/ni65.c
Original file line number Diff line number Diff line change
@@ -1028,7 +1028,7 @@ static void ni65_xmit_intr(struct net_device *dev,int csr0)

#ifdef XMT_VIA_SKB
if(p->tmd_skb[p->tmdlast]) {
dev_kfree_skb_irq(p->tmd_skb[p->tmdlast]);
dev_consume_skb_irq(p->tmd_skb[p->tmdlast]);
p->tmd_skb[p->tmdlast] = NULL;
}
#endif

0 comments on commit fc67ade

Please sign in to comment.