Skip to content

Commit

Permalink
net: dsa: lantiq_gswip: delete irrelevant use of ds->phys_mii_mask
Browse files Browse the repository at this point in the history
__of_mdiobus_register(), called right next, overwrites the phy_mask
we just configured on the bus, so this is redundant and confusing.
Delete it.

Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
Reviewed-by: Alvin Šipraga <alsi@bang-olufsen.dk>
Reviewed-by: Florian Fainelli <florian.fainelli@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Vladimir Oltean authored and David S. Miller committed Jan 5, 2024
1 parent 94e2557 commit fc74b32
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion drivers/net/dsa/lantiq_gswip.c
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,6 @@ static int gswip_mdio(struct gswip_priv *priv, struct device_node *mdio_np)
snprintf(ds->user_mii_bus->id, MII_BUS_ID_SIZE, "%s-mii",
dev_name(priv->dev));
ds->user_mii_bus->parent = priv->dev;
ds->user_mii_bus->phy_mask = ~ds->phys_mii_mask;

err = of_mdiobus_register(ds->user_mii_bus, mdio_np);
if (err)
Expand Down

0 comments on commit fc74b32

Please sign in to comment.