Skip to content

Commit

Permalink
Bluetooth: L2CAP: fix "bad unlock balance" in l2cap_disconnect_rsp
Browse files Browse the repository at this point in the history
[ Upstream commit 25e97f7 ]

conn->chan_lock isn't acquired before l2cap_get_chan_by_scid,
if l2cap_get_chan_by_scid returns NULL, then 'bad unlock balance'
is triggered.

Reported-by: syzbot+9519d6b5b79cf7787cf3@syzkaller.appspotmail.com
Link: https://lore.kernel.org/all/000000000000894f5f05f95e9f4d@google.com/
Signed-off-by: Min Li <lm0963hack@gmail.com>
Signed-off-by: Luiz Augusto von Dentz <luiz.von.dentz@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Min Li authored and Greg Kroah-Hartman committed May 24, 2023
1 parent 2f4a1b2 commit fd269a0
Showing 1 changed file with 0 additions and 1 deletion.
1 change: 0 additions & 1 deletion net/bluetooth/l2cap_core.c
Original file line number Diff line number Diff line change
@@ -4694,7 +4694,6 @@ static inline int l2cap_disconnect_rsp(struct l2cap_conn *conn,

chan = l2cap_get_chan_by_scid(conn, scid);
if (!chan) {
mutex_unlock(&conn->chan_lock);
return 0;
}

0 comments on commit fd269a0

Please sign in to comment.