Skip to content

Commit

Permalink
tcp: Validate route interface in early demux.
Browse files Browse the repository at this point in the history
Otherwise we might violate reverse path filtering.

Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
David S. Miller committed Jun 21, 2012
1 parent 3e428fe commit fd62e09
Showing 1 changed file with 9 additions and 3 deletions.
12 changes: 9 additions & 3 deletions net/ipv4/tcp_ipv4.c
Original file line number Diff line number Diff line change
Expand Up @@ -1676,6 +1676,7 @@ int tcp_v4_early_demux(struct sk_buff *skb)
struct net *net = dev_net(skb->dev);
const struct iphdr *iph;
const struct tcphdr *th;
struct net_device *dev;
struct sock *sk;
int err;

Expand All @@ -1695,10 +1696,11 @@ int tcp_v4_early_demux(struct sk_buff *skb)
if (!pskb_may_pull(skb, ip_hdrlen(skb) + th->doff * 4))
goto out_err;

dev = skb->dev;
sk = __inet_lookup_established(net, &tcp_hashinfo,
iph->saddr, th->source,
iph->daddr, th->dest,
skb->dev->ifindex);
dev->ifindex);
if (sk) {
skb->sk = sk;
skb->destructor = sock_edemux;
Expand All @@ -1707,8 +1709,12 @@ int tcp_v4_early_demux(struct sk_buff *skb)
if (dst)
dst = dst_check(dst, 0);
if (dst) {
skb_dst_set_noref(skb, dst);
err = 0;
struct rtable *rt = (struct rtable *) dst;

if (rt->rt_iif == dev->ifindex) {
skb_dst_set_noref(skb, dst);
err = 0;
}
}
}
}
Expand Down

0 comments on commit fd62e09

Please sign in to comment.