Skip to content

Commit

Permalink
ACPI: x86: s2idle: If a new AMD _HID is missing assume Rembrandt
Browse files Browse the repository at this point in the history
A mistake was made that only AMDI0007 was set to rev of "2", but
it should have been also set for AMDI008. If an ID is missing from
the _HID table, then assume it matches Rembrandt behavior.

This implicitly means that if any other behavior changes happen
in the future missing IDs must be added to that table.

Tested-by: catalin@antebit.com
Reviewed-by: Philipp Zabel <philipp.zabel@gmail.com>
Tested-by: Philipp Zabel <philipp.zabel@gmail.com> # GA402RJ
Signed-off-by: Mario Limonciello <mario.limonciello@amd.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Mario Limonciello authored and Rafael J. Wysocki committed Sep 25, 2022
1 parent 100a573 commit fd894f0
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/acpi/x86/s2idle.c
Original file line number Diff line number Diff line change
Expand Up @@ -412,7 +412,7 @@ static int lps0_device_attach(struct acpi_device *adev,
if (dev_id)
data = (const struct amd_lps0_hid_device_data *) dev_id->driver_data;
else
return 0;
data = &amd_rembrandt;
rev_id = data->rev_id;
lps0_dsm_func_mask = validate_dsm(adev->handle,
ACPI_LPS0_DSM_UUID_AMD, rev_id, &lps0_dsm_guid);
Expand Down

0 comments on commit fd894f0

Please sign in to comment.