Skip to content

Commit

Permalink
x86: x86 ptrace generic requests
Browse files Browse the repository at this point in the history
This removes duplicated code by calling the generic ptrace_request and
compat_ptrace_request functions for the things they already handle.

Signed-off-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Signed-off-by: Thomas Gleixner <tglx@linutronix.de>
  • Loading branch information
Roland McGrath authored and Ingo Molnar committed Jan 30, 2008
1 parent bb61682 commit fdadd54
Showing 1 changed file with 1 addition and 36 deletions.
37 changes: 1 addition & 36 deletions arch/x86/kernel/ptrace.c
Original file line number Diff line number Diff line change
Expand Up @@ -760,12 +760,6 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
unsigned long __user *datap = (unsigned long __user *)data;

switch (request) {
/* when I and D space are separate, these will need to be fixed. */
case PTRACE_PEEKTEXT: /* read word at location addr. */
case PTRACE_PEEKDATA:
ret = generic_ptrace_peekdata(child, addr, data);
break;

/* read the word at location addr in the USER area. */
case PTRACE_PEEKUSR: {
unsigned long tmp;
Expand All @@ -787,12 +781,6 @@ long arch_ptrace(struct task_struct *child, long request, long addr, long data)
break;
}

/* when I and D space are separate, this will have to be fixed. */
case PTRACE_POKETEXT: /* write the word at location addr. */
case PTRACE_POKEDATA:
ret = generic_ptrace_pokedata(child, addr, data);
break;

case PTRACE_POKEUSR: /* write the word at location addr in the USER area */
ret = -EIO;
if ((addr & (sizeof(data) - 1)) || addr < 0 ||
Expand Down Expand Up @@ -1183,24 +1171,6 @@ asmlinkage long sys32_ptrace(long request, u32 pid, u32 addr, u32 data)
childregs = task_pt_regs(child);

switch (request) {
case PTRACE_PEEKDATA:
case PTRACE_PEEKTEXT:
ret = 0;
if (access_process_vm(child, addr, &val, sizeof(u32), 0) !=
sizeof(u32))
ret = -EIO;
else
ret = put_user(val, (unsigned int __user *)datap);
break;

case PTRACE_POKEDATA:
case PTRACE_POKETEXT:
ret = 0;
if (access_process_vm(child, addr, &data, sizeof(u32), 1) !=
sizeof(u32))
ret = -EIO;
break;

case PTRACE_PEEKUSR:
ret = getreg32(child, addr, &val);
if (ret == 0)
Expand Down Expand Up @@ -1246,13 +1216,8 @@ asmlinkage long sys32_ptrace(long request, u32 pid, u32 addr, u32 data)
sizeof(struct user32_fxsr_struct),
datap);

case PTRACE_GETEVENTMSG:
ret = put_user(child->ptrace_message,
(unsigned int __user *)compat_ptr(data));
break;

default:
BUG();
return compat_ptrace_request(child, request, addr, data);
}

out:
Expand Down

0 comments on commit fdadd54

Please sign in to comment.