Skip to content

Commit

Permalink
iio: gyro: adxrs290: fix data signedness
Browse files Browse the repository at this point in the history
Properly sign-extend the rate and temperature data.

Fixes: 2c8920f ("iio: gyro: Add driver support for ADXRS290")
Signed-off-by: Kister Genesis Jimenez <kister.jimenez@analog.com>
Signed-off-by: Nuno Sá <nuno.sa@analog.com>
Reviewed-by: Andy Shevchenko <andy.shevchenko@gmail.com>
Link: https://lore.kernel.org/r/20211115104147.18669-1-nuno.sa@analog.com
Cc: <Stable@vger.kernel.org>
Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
  • Loading branch information
Kister Genesis Jimenez authored and Jonathan Cameron committed Nov 21, 2021
1 parent 6661146 commit fde272e
Showing 1 changed file with 3 additions and 2 deletions.
5 changes: 3 additions & 2 deletions drivers/iio/gyro/adxrs290.c
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
*/

#include <linux/bitfield.h>
#include <linux/bitops.h>
#include <linux/delay.h>
#include <linux/device.h>
#include <linux/kernel.h>
Expand Down Expand Up @@ -124,7 +125,7 @@ static int adxrs290_get_rate_data(struct iio_dev *indio_dev, const u8 cmd, int *
goto err_unlock;
}

*val = temp;
*val = sign_extend32(temp, 15);

err_unlock:
mutex_unlock(&st->lock);
Expand All @@ -146,7 +147,7 @@ static int adxrs290_get_temp_data(struct iio_dev *indio_dev, int *val)
}

/* extract lower 12 bits temperature reading */
*val = temp & 0x0FFF;
*val = sign_extend32(temp, 11);

err_unlock:
mutex_unlock(&st->lock);
Expand Down

0 comments on commit fde272e

Please sign in to comment.