Skip to content

Commit

Permalink
dm cache policy mq: remove unused generation member of struct entry
Browse files Browse the repository at this point in the history
Remove to stop wasting memory.

Signed-off-by: Joe Thornber <ejt@redhat.com>
Signed-off-by: Mike Snitzer <snitzer@redhat.com>
  • Loading branch information
Joe Thornber authored and Mike Snitzer committed Mar 31, 2015
1 parent 3e45c91 commit fdecee3
Showing 1 changed file with 0 additions and 5 deletions.
5 changes: 0 additions & 5 deletions drivers/md/dm-cache-policy-mq.c
Original file line number Diff line number Diff line change
Expand Up @@ -253,7 +253,6 @@ struct entry {
*/
bool dirty:1;
unsigned hit_count;
unsigned generation;
};

/*
Expand Down Expand Up @@ -744,7 +743,6 @@ static int pre_cache_to_cache(struct mq_policy *mq, struct entry *e,
new_e->oblock = e->oblock;
new_e->dirty = false;
new_e->hit_count = e->hit_count;
new_e->generation = e->generation;

del(mq, e);
free_entry(&mq->pre_cache_pool, e);
Expand Down Expand Up @@ -796,7 +794,6 @@ static void insert_in_pre_cache(struct mq_policy *mq,
e->dirty = false;
e->oblock = oblock;
e->hit_count = 1;
e->generation = mq->generation;
push(mq, e);
}

Expand Down Expand Up @@ -829,7 +826,6 @@ static void insert_in_cache(struct mq_policy *mq, dm_oblock_t oblock,
e->oblock = oblock;
e->dirty = false;
e->hit_count = 1;
e->generation = mq->generation;
push(mq, e);

result->cblock = infer_cblock(&mq->cache_pool, e);
Expand Down Expand Up @@ -1026,7 +1022,6 @@ static int mq_load_mapping(struct dm_cache_policy *p,
e->oblock = oblock;
e->dirty = false; /* this gets corrected in a minute */
e->hit_count = hint_valid ? hint : 1;
e->generation = mq->generation;
push(mq, e);

return 0;
Expand Down

0 comments on commit fdecee3

Please sign in to comment.