Skip to content

Commit

Permalink
wireless: wl12xx, fix lock imbalance
Browse files Browse the repository at this point in the history
Add omitted mutex_unlock to one of wl12xx_op_start fail paths (when
wl12xx_chip_wakeup fails).

[v2]
Power off the device, because:
\= cite from http://marc.info/?l=linux-kernel&m=124755028209880&w=2
If the chip cannot be booted, why should it remain powered on?
In some rare cases, the chip might fail to initialize, but can
recover if powered off and on again, so turning it off at this
point is the right thing to do. =/

Signed-off-by: Jiri Slaby <jirislaby@gmail.com>
Reviewed-by: Luciano Coelho <luciano.coelho@nokia.com>
Signed-off-by: John W. Linville <linville@tuxdriver.com>
  • Loading branch information
Jiri Slaby authored and John W. Linville committed Jul 24, 2009
1 parent a94ca4e commit fe64341
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/wireless/wl12xx/wl1251_main.c
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ static int wl1251_op_start(struct ieee80211_hw *hw)

ret = wl1251_chip_wakeup(wl);
if (ret < 0)
return ret;
goto out;

ret = wl->chip.op_boot(wl);
if (ret < 0)
Expand Down

0 comments on commit fe64341

Please sign in to comment.