Skip to content

Commit

Permalink
ACPI: bus: Refactor ACPI matching functions for better readability
Browse files Browse the repository at this point in the history
With temporary variables for OF and ACPI IDs, it's easier to read
the code. No functional change intended.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
  • Loading branch information
Andy Shevchenko authored and Rafael J. Wysocki committed Sep 3, 2022
1 parent 1cd43ac commit fe79e39
Showing 1 changed file with 10 additions and 10 deletions.
20 changes: 10 additions & 10 deletions drivers/acpi/bus.c
Original file line number Diff line number Diff line change
Expand Up @@ -925,12 +925,13 @@ static const void *acpi_of_device_get_match_data(const struct device *dev)

const void *acpi_device_get_match_data(const struct device *dev)
{
const struct acpi_device_id *acpi_ids = dev->driver->acpi_match_table;
const struct acpi_device_id *match;

if (!dev->driver->acpi_match_table)
if (!acpi_ids)
return acpi_of_device_get_match_data(dev);

match = acpi_match_device(dev->driver->acpi_match_table, dev);
match = acpi_match_device(acpi_ids, dev);
if (!match)
return NULL;

Expand All @@ -948,14 +949,13 @@ EXPORT_SYMBOL(acpi_match_device_ids);
bool acpi_driver_match_device(struct device *dev,
const struct device_driver *drv)
{
if (!drv->acpi_match_table)
return acpi_of_match_device(ACPI_COMPANION(dev),
drv->of_match_table,
NULL);

return __acpi_match_device(acpi_companion_match(dev),
drv->acpi_match_table, drv->of_match_table,
NULL, NULL);
const struct acpi_device_id *acpi_ids = drv->acpi_match_table;
const struct of_device_id *of_ids = drv->of_match_table;

if (!acpi_ids)
return acpi_of_match_device(ACPI_COMPANION(dev), of_ids, NULL);

return __acpi_match_device(acpi_companion_match(dev), acpi_ids, of_ids, NULL, NULL);
}
EXPORT_SYMBOL_GPL(acpi_driver_match_device);

Expand Down

0 comments on commit fe79e39

Please sign in to comment.