Skip to content

Commit

Permalink
memblock tests: remove completed TODO items
Browse files Browse the repository at this point in the history
Remove completed items from TODO list.

Signed-off-by: Rebecca Mckeever <remckee0@gmail.com>
Signed-off-by: Mike Rapoport <rppt@linux.ibm.com>
Link: https://lore.kernel.org/r/6a3e74fcb51a07e8d9fbbcbe84bdb8aa8b00e843.1656907314.git.remckee0@gmail.com
  • Loading branch information
Rebecca Mckeever authored and Mike Rapoport committed Jul 4, 2022
1 parent c55b31a commit fe833b4
Showing 1 changed file with 3 additions and 11 deletions.
14 changes: 3 additions & 11 deletions tools/testing/memblock/TODO
Original file line number Diff line number Diff line change
@@ -1,25 +1,17 @@
TODO
=====

1. Add verbose output (e.g., what is being tested and how many tests cases are
passing)

2. Add flags to Makefile:
+ verbosity level
+ enable memblock_dbg() messages (i.e. pass "-D CONFIG_DEBUG_MEMORY_INIT"
flag)

3. Add tests trying to memblock_add() or memblock_reserve() 129th region.
1. Add tests trying to memblock_add() or memblock_reserve() 129th region.
This will trigger memblock_double_array(), make sure it succeeds.
*Important:* These tests require valid memory ranges, use dummy physical
memory block from common.c to implement them. It is also very
likely that the current MEM_SIZE won't be enough for these
test cases. Use realloc to adjust the size accordingly.

4. Add test cases using this functions (implement them for both directions):
2. Add test cases using this functions (implement them for both directions):
+ memblock_alloc_raw()
+ memblock_alloc_exact_nid_raw()
+ memblock_alloc_try_nid_raw()

5. Add tests for memblock_alloc_node() to check if the correct NUMA node is set
3. Add tests for memblock_alloc_node() to check if the correct NUMA node is set
for the new region

0 comments on commit fe833b4

Please sign in to comment.