Skip to content

Commit

Permalink
block: remove superfluous check for request queue in bdev_is_zoned()
Browse files Browse the repository at this point in the history
Remove the superfluous request queue check in bdev_is_zoned() as
bdev_get_queue() can never return NULL.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
Reviewed-by: Bart Van Assche <bvanassche@acm.org>
Reviewed-by: Chaitanya Kulkarni <kch@nvidia.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Signed-off-by: Pankaj Raghav <p.raghav@samsung.com>
Link: https://lore.kernel.org/r/20230110143635.77300-2-p.raghav@samsung.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
  • Loading branch information
Pankaj Raghav authored and Jens Axboe committed Jan 29, 2023
1 parent 7e2e355 commit fea127b
Showing 1 changed file with 1 addition and 6 deletions.
7 changes: 1 addition & 6 deletions include/linux/blkdev.h
Original file line number Diff line number Diff line change
Expand Up @@ -1285,12 +1285,7 @@ static inline enum blk_zoned_model bdev_zoned_model(struct block_device *bdev)

static inline bool bdev_is_zoned(struct block_device *bdev)
{
struct request_queue *q = bdev_get_queue(bdev);

if (q)
return blk_queue_is_zoned(q);

return false;
return blk_queue_is_zoned(bdev_get_queue(bdev));
}

static inline bool bdev_op_is_zoned_write(struct block_device *bdev,
Expand Down

0 comments on commit fea127b

Please sign in to comment.