Skip to content

Commit

Permalink
signal: retarget_shared_pending: optimize while_each_thread() loop
Browse files Browse the repository at this point in the history
retarget_shared_pending() blindly does recalc_sigpending_and_wake() for
every sub-thread, this is suboptimal. We can check t->blocked and stop
looping once every bit in shared_pending has the new target.

Note: we do not take task_is_stopped_or_traced(t) into account, we are
not trying to speed up the signal delivery or to avoid the unnecessary
(but harmless) signal_wake_up(0) in this unlikely case.

Signed-off-by: Oleg Nesterov <oleg@redhat.com>
Reviewed-by: Matt Fleming <matt.fleming@linux.intel.com>
Acked-by: Tejun Heo <tj@kernel.org>
  • Loading branch information
Oleg Nesterov committed Apr 28, 2011
1 parent f646e22 commit fec9993
Showing 1 changed file with 15 additions and 4 deletions.
19 changes: 15 additions & 4 deletions kernel/signal.c
Original file line number Diff line number Diff line change
Expand Up @@ -2200,8 +2200,8 @@ int get_signal_to_deliver(siginfo_t *info, struct k_sigaction *return_ka,

/*
* It could be that complete_signal() picked us to notify about the
* group-wide signal. Another thread should be notified now to take
* the signal since we will not.
* group-wide signal. Other threads should be notified now to take
* the shared signals in @which since we will not.
*/
static void retarget_shared_pending(struct task_struct *tsk, sigset_t *which)
{
Expand All @@ -2214,8 +2214,19 @@ static void retarget_shared_pending(struct task_struct *tsk, sigset_t *which)

t = tsk;
while_each_thread(tsk, t) {
if (!signal_pending(t) && !(t->flags & PF_EXITING))
recalc_sigpending_and_wake(t);
if (t->flags & PF_EXITING)
continue;

if (!has_pending_signals(&retarget, &t->blocked))
continue;
/* Remove the signals this thread can handle. */
sigandsets(&retarget, &retarget, &t->blocked);

if (!signal_pending(t))
signal_wake_up(t, 0);

if (sigisemptyset(&retarget))
break;
}
}

Expand Down

0 comments on commit fec9993

Please sign in to comment.