Skip to content

Commit

Permalink
KVM: arm64: selftests: Refactor debug-exceptions to make it amenable …
Browse files Browse the repository at this point in the history
…to new test cases

Split up the current test into a helper, but leave the debug version
checking in main(), to make it convenient to add a new debug exception
test case in a subsequent patch.

Signed-off-by: Reiji Watanabe <reijiw@google.com>
Signed-off-by: Marc Zyngier <maz@kernel.org>
Link: https://lore.kernel.org/r/20220917010600.532642-4-reijiw@google.com
  • Loading branch information
Reiji Watanabe authored and Marc Zyngier committed Sep 19, 2022
1 parent 370531d commit ff00e73
Showing 1 changed file with 14 additions and 4 deletions.
18 changes: 14 additions & 4 deletions tools/testing/selftests/kvm/aarch64/debug-exceptions.c
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ static int debug_version(struct kvm_vcpu *vcpu)
return id_aa64dfr0 & 0xf;
}

int main(int argc, char *argv[])
static void test_guest_debug_exceptions(void)
{
struct kvm_vcpu *vcpu;
struct kvm_vm *vm;
Expand All @@ -259,9 +259,6 @@ int main(int argc, char *argv[])
vm_init_descriptor_tables(vm);
vcpu_init_descriptor_tables(vcpu);

__TEST_REQUIRE(debug_version(vcpu) >= 6,
"Armv8 debug architecture not supported.");

vm_install_sync_handler(vm, VECTOR_SYNC_CURRENT,
ESR_EC_BRK_INS, guest_sw_bp_handler);
vm_install_sync_handler(vm, VECTOR_SYNC_CURRENT,
Expand Down Expand Up @@ -294,5 +291,18 @@ int main(int argc, char *argv[])

done:
kvm_vm_free(vm);
}

int main(int argc, char *argv[])
{
struct kvm_vcpu *vcpu;
struct kvm_vm *vm;

vm = vm_create_with_one_vcpu(&vcpu, guest_code);
__TEST_REQUIRE(debug_version(vcpu) >= 6,
"Armv8 debug architecture not supported.");
kvm_vm_free(vm);
test_guest_debug_exceptions();

return 0;
}

0 comments on commit ff00e73

Please sign in to comment.