Skip to content

Commit

Permalink
mmc: sdhci-bcm-kona: Use sdhci_pltfm_unregister instead of open coded
Browse files Browse the repository at this point in the history
This avoid duplicated implementation and also fixes missing iounmap() and
release_mem_region() calls in sdhci_bcm_kona_remove().  sdhci_pltfm_init()
calls request_mem_region() and ioremap(), thus we need to call the
corresponding iounmap() and release_mem_region() calls in
sdhci_bcm_kona_remove().

Signed-off-by: Axel Lin <axel.lin@ingics.com>
Signed-off-by: Chris Ball <cjb@laptop.org>
  • Loading branch information
Axel Lin authored and Chris Ball committed Sep 26, 2013
1 parent 08de89b commit ff1acfd
Showing 1 changed file with 1 addition and 13 deletions.
14 changes: 1 addition & 13 deletions drivers/mmc/host/sdhci-bcm-kona.c
Original file line number Diff line number Diff line change
Expand Up @@ -316,19 +316,7 @@ static int sdhci_bcm_kona_probe(struct platform_device *pdev)

static int __exit sdhci_bcm_kona_remove(struct platform_device *pdev)
{
struct sdhci_host *host = platform_get_drvdata(pdev);
int dead;
u32 scratch;

dead = 0;
scratch = readl(host->ioaddr + SDHCI_INT_STATUS);
if (scratch == (u32)-1)
dead = 1;
sdhci_remove_host(host, dead);

sdhci_free_host(host);

return 0;
return sdhci_pltfm_unregister(pdev);
}

static struct platform_driver sdhci_bcm_kona_driver = {
Expand Down

0 comments on commit ff1acfd

Please sign in to comment.