Skip to content

Commit

Permalink
misc: fastrpc: Rename tgid and pid to client_id
Browse files Browse the repository at this point in the history
The information passed as request tgid and pid is actually the
client id of the process. This client id is used as an
identifier by DSP to identify the DSP PD corresponding to the
process. Currently process tgid is getting passed as the
identifier which is getting replaced by a custom client id.
Rename the data which uses this client id.

Signed-off-by: Ekansh Gupta <quic_ekangupt@quicinc.com>
Reviewed-by: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Signed-off-by: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
Link: https://lore.kernel.org/r/20250110134308.123739-3-srinivas.kandagatla@linaro.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Ekansh Gupta authored and Greg Kroah-Hartman committed Jan 10, 2025
1 parent 37d56e0 commit ff5e0c8
Showing 1 changed file with 24 additions and 24 deletions.
48 changes: 24 additions & 24 deletions drivers/misc/fastrpc.c
Original file line number Diff line number Diff line change
Expand Up @@ -139,14 +139,14 @@ struct fastrpc_mmap_rsp_msg {
};

struct fastrpc_mmap_req_msg {
s32 pgid;
s32 client_id;
u32 flags;
u64 vaddr;
s32 num;
};

struct fastrpc_mem_map_req_msg {
s32 pgid;
s32 client_id;
s32 fd;
s32 offset;
u32 flags;
Expand All @@ -156,20 +156,20 @@ struct fastrpc_mem_map_req_msg {
};

struct fastrpc_munmap_req_msg {
s32 pgid;
s32 client_id;
u64 vaddr;
u64 size;
};

struct fastrpc_mem_unmap_req_msg {
s32 pgid;
s32 client_id;
s32 fd;
u64 vaddrin;
u64 len;
};

struct fastrpc_msg {
int pid; /* process group id */
int client_id; /* process client id */
int tid; /* thread id */
u64 ctx; /* invoke caller context */
u32 handle; /* handle to invoke */
Expand Down Expand Up @@ -234,7 +234,7 @@ struct fastrpc_invoke_ctx {
int nbufs;
int retval;
int pid;
int tgid;
int client_id;
u32 sc;
u32 *crc;
u64 ctxid;
Expand Down Expand Up @@ -614,7 +614,7 @@ static struct fastrpc_invoke_ctx *fastrpc_context_alloc(
ctx->sc = sc;
ctx->retval = -1;
ctx->pid = current->pid;
ctx->tgid = user->client_id;
ctx->client_id = user->client_id;
ctx->cctx = cctx;
init_completion(&ctx->work);
INIT_WORK(&ctx->put_work, fastrpc_context_put_wq);
Expand Down Expand Up @@ -1115,11 +1115,11 @@ static int fastrpc_invoke_send(struct fastrpc_session_ctx *sctx,
int ret;

cctx = fl->cctx;
msg->pid = fl->client_id;
msg->client_id = fl->client_id;
msg->tid = current->pid;

if (kernel)
msg->pid = 0;
msg->client_id = 0;

msg->ctx = ctx->ctxid | fl->pd;
msg->handle = handle;
Expand Down Expand Up @@ -1244,7 +1244,7 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl,
int err;
bool scm_done = false;
struct {
int pgid;
int client_id;
u32 namelen;
u32 pageslen;
} inbuf;
Expand Down Expand Up @@ -1293,7 +1293,7 @@ static int fastrpc_init_create_static_process(struct fastrpc_user *fl,
}
}

inbuf.pgid = fl->client_id;
inbuf.client_id = fl->client_id;
inbuf.namelen = init.namelen;
inbuf.pageslen = 0;
fl->pd = USER_PD;
Expand Down Expand Up @@ -1363,7 +1363,7 @@ static int fastrpc_init_create_process(struct fastrpc_user *fl,
int memlen;
int err;
struct {
int pgid;
int client_id;
u32 namelen;
u32 filelen;
u32 pageslen;
Expand Down Expand Up @@ -1395,7 +1395,7 @@ static int fastrpc_init_create_process(struct fastrpc_user *fl,
goto err;
}

inbuf.pgid = fl->client_id;
inbuf.client_id = fl->client_id;
inbuf.namelen = strlen(current->comm) + 1;
inbuf.filelen = init.filelen;
inbuf.pageslen = 1;
Expand Down Expand Up @@ -1504,12 +1504,12 @@ static void fastrpc_session_free(struct fastrpc_channel_ctx *cctx,
static int fastrpc_release_current_dsp_process(struct fastrpc_user *fl)
{
struct fastrpc_invoke_args args[1];
int tgid = 0;
int client_id = 0;
u32 sc;

tgid = fl->client_id;
args[0].ptr = (u64)(uintptr_t) &tgid;
args[0].length = sizeof(tgid);
client_id = fl->client_id;
args[0].ptr = (u64)(uintptr_t) &client_id;
args[0].length = sizeof(client_id);
args[0].fd = -1;
sc = FASTRPC_SCALARS(FASTRPC_RMID_INIT_RELEASE, 1, 0);

Expand Down Expand Up @@ -1649,11 +1649,11 @@ static int fastrpc_dmabuf_alloc(struct fastrpc_user *fl, char __user *argp)
static int fastrpc_init_attach(struct fastrpc_user *fl, int pd)
{
struct fastrpc_invoke_args args[1];
int tgid = fl->client_id;
int client_id = fl->client_id;
u32 sc;

args[0].ptr = (u64)(uintptr_t) &tgid;
args[0].length = sizeof(tgid);
args[0].ptr = (u64)(uintptr_t) &client_id;
args[0].length = sizeof(client_id);
args[0].fd = -1;
sc = FASTRPC_SCALARS(FASTRPC_RMID_INIT_ATTACH, 1, 0);
fl->pd = pd;
Expand Down Expand Up @@ -1805,7 +1805,7 @@ static int fastrpc_req_munmap_impl(struct fastrpc_user *fl, struct fastrpc_buf *
int err;
u32 sc;

req_msg.pgid = fl->client_id;
req_msg.client_id = fl->client_id;
req_msg.size = buf->size;
req_msg.vaddr = buf->raddr;

Expand Down Expand Up @@ -1891,7 +1891,7 @@ static int fastrpc_req_mmap(struct fastrpc_user *fl, char __user *argp)
return err;
}

req_msg.pgid = fl->client_id;
req_msg.client_id = fl->client_id;
req_msg.flags = req.flags;
req_msg.vaddr = req.vaddrin;
req_msg.num = sizeof(pages);
Expand Down Expand Up @@ -1980,7 +1980,7 @@ static int fastrpc_req_mem_unmap_impl(struct fastrpc_user *fl, struct fastrpc_me
return -EINVAL;
}

req_msg.pgid = fl->client_id;
req_msg.client_id = fl->client_id;
req_msg.len = map->len;
req_msg.vaddrin = map->raddr;
req_msg.fd = map->fd;
Expand Down Expand Up @@ -2033,7 +2033,7 @@ static int fastrpc_req_mem_map(struct fastrpc_user *fl, char __user *argp)
return err;
}

req_msg.pgid = fl->client_id;
req_msg.client_id = fl->client_id;
req_msg.fd = req.fd;
req_msg.offset = req.offset;
req_msg.vaddrin = req.vaddrin;
Expand Down

0 comments on commit ff5e0c8

Please sign in to comment.