Skip to content

Commit

Permalink
net: dsa: mv88e6xxx: Unlock on error in mv88e6xxx_port_bridge_join()
Browse files Browse the repository at this point in the history
Call mv88e6xxx_reg_unlock(chip) before returning on this error path.

Fixes: 7af4a36 ("net: dsa: mv88e6xxx: Improve isolation of standalone ports")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
  • Loading branch information
Dan Carpenter authored and David S. Miller committed Feb 7, 2022
1 parent dde41a6 commit ff62433
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/dsa/mv88e6xxx/chip.c
Original file line number Diff line number Diff line change
Expand Up @@ -2602,7 +2602,7 @@ static int mv88e6xxx_port_bridge_join(struct dsa_switch *ds, int port,

err = mv88e6xxx_port_set_map_da(chip, port, true);
if (err)
return err;
goto unlock;

err = mv88e6xxx_port_commit_pvid(chip, port);
if (err)
Expand Down

0 comments on commit ff62433

Please sign in to comment.