Skip to content

Commit

Permalink
spmi: Auto-populate driver.owner in spmi_driver_register()
Browse files Browse the repository at this point in the history
Populate the owner field of the spmi driver when
spmi_driver_register() is called in a similar fashion to how
other *_driver_register() functions do it. This saves driver
writers from having to do this themselves.

Cc: Andy Gross <agross@codeaurora.org>
Cc: Gilad Avidov <gavidov@codeaurora.org>
Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Stephen Boyd authored and Greg Kroah-Hartman committed Sep 21, 2015
1 parent cf094eb commit ff6f464
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 3 deletions.
5 changes: 3 additions & 2 deletions drivers/spmi/spmi.c
Original file line number Diff line number Diff line change
Expand Up @@ -560,12 +560,13 @@ EXPORT_SYMBOL_GPL(spmi_controller_remove);
* This API will register the client driver with the SPMI framework.
* It is typically called from the driver's module-init function.
*/
int spmi_driver_register(struct spmi_driver *sdrv)
int __spmi_driver_register(struct spmi_driver *sdrv, struct module *owner)
{
sdrv->driver.bus = &spmi_bus_type;
sdrv->driver.owner = owner;
return driver_register(&sdrv->driver);
}
EXPORT_SYMBOL_GPL(spmi_driver_register);
EXPORT_SYMBOL_GPL(__spmi_driver_register);

static void __exit spmi_exit(void)
{
Expand Down
4 changes: 3 additions & 1 deletion include/linux/spmi.h
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,9 @@ static inline struct spmi_driver *to_spmi_driver(struct device_driver *d)
return container_of(d, struct spmi_driver, driver);
}

int spmi_driver_register(struct spmi_driver *sdrv);
#define spmi_driver_register(sdrv) \
__spmi_driver_register(sdrv, THIS_MODULE)
int __spmi_driver_register(struct spmi_driver *sdrv, struct module *owner);

/**
* spmi_driver_unregister() - unregister an SPMI client driver
Expand Down

0 comments on commit ff6f464

Please sign in to comment.