Skip to content

Commit

Permalink
staging: erofs: correct all misused ENOTSUPP
Browse files Browse the repository at this point in the history
As Chao pointed out [1], ENOTSUPP is used for NFS
protocol only, we should use EOPNOTSUPP instead...

[1] https://lore.kernel.org/lkml/108ee2f9-75dd-b8ab-8da7-b81c17bafbf6@huawei.com/

Reported-by: Chao Yu <yuchao0@huawei.com>
Signed-off-by: Gao Xiang <gaoxiang25@huawei.com>
Reviewed-by: Chao Yu <yuchao0@huawei.com>
Link: https://lore.kernel.org/r/20190814103705.60698-3-gaoxiang25@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Gao Xiang authored and Greg Kroah-Hartman committed Aug 15, 2019
1 parent 382329a commit ff784a7
Show file tree
Hide file tree
Showing 5 changed files with 11 additions and 11 deletions.
2 changes: 1 addition & 1 deletion drivers/staging/erofs/decompressor.c
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ static int lz4_decompress(struct z_erofs_decompress_req *rq, u8 *out)
int ret;

if (rq->inputsize > PAGE_SIZE)
return -ENOTSUPP;
return -EOPNOTSUPP;

src = kmap_atomic(*rq->in);
inputmargin = 0;
Expand Down
6 changes: 3 additions & 3 deletions drivers/staging/erofs/internal.h
Original file line number Diff line number Diff line change
Expand Up @@ -403,12 +403,12 @@ int z_erofs_map_blocks_iter(struct inode *inode,
struct erofs_map_blocks *map,
int flags);
#else
static inline int z_erofs_fill_inode(struct inode *inode) { return -ENOTSUPP; }
static inline int z_erofs_fill_inode(struct inode *inode) { return -EOPNOTSUPP; }
static inline int z_erofs_map_blocks_iter(struct inode *inode,
struct erofs_map_blocks *map,
int flags)
{
return -ENOTSUPP;
return -EOPNOTSUPP;
}
#endif /* !CONFIG_EROFS_FS_ZIP */

Expand Down Expand Up @@ -516,7 +516,7 @@ void *erofs_get_pcpubuf(unsigned int pagenr);
#else
static inline void *erofs_get_pcpubuf(unsigned int pagenr)
{
return ERR_PTR(-ENOTSUPP);
return ERR_PTR(-EOPNOTSUPP);
}

#define erofs_put_pcpubuf(buf) do {} while (0)
Expand Down
2 changes: 1 addition & 1 deletion drivers/staging/erofs/xattr.c
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ static int init_inode_xattrs(struct inode *inode)
if (vi->xattr_isize == sizeof(struct erofs_xattr_ibody_header)) {
errln("xattr_isize %d of nid %llu is not supported yet",
vi->xattr_isize, vi->nid);
ret = -ENOTSUPP;
ret = -EOPNOTSUPP;
goto out_unlock;
} else if (vi->xattr_isize < sizeof(struct erofs_xattr_ibody_header)) {
if (unlikely(vi->xattr_isize)) {
Expand Down
4 changes: 2 additions & 2 deletions drivers/staging/erofs/xattr.h
Original file line number Diff line number Diff line change
Expand Up @@ -74,13 +74,13 @@ static inline int erofs_getxattr(struct inode *inode, int index,
const char *name, void *buffer,
size_t buffer_size)
{
return -ENOTSUPP;
return -EOPNOTSUPP;
}

static inline ssize_t erofs_listxattr(struct dentry *dentry,
char *buffer, size_t buffer_size)
{
return -ENOTSUPP;
return -EOPNOTSUPP;
}
#endif /* !CONFIG_EROFS_FS_XATTR */

Expand Down
8 changes: 4 additions & 4 deletions drivers/staging/erofs/zmap.c
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ static int fill_inode_lazy(struct inode *inode)
if (vi->z_algorithmtype[0] >= Z_EROFS_COMPRESSION_MAX) {
errln("unknown compression format %u for nid %llu, please upgrade kernel",
vi->z_algorithmtype[0], vi->nid);
err = -ENOTSUPP;
err = -EOPNOTSUPP;
goto unmap_done;
}

Expand All @@ -79,7 +79,7 @@ static int fill_inode_lazy(struct inode *inode)
if (vi->z_physical_clusterbits[0] != LOG_BLOCK_SIZE) {
errln("unsupported physical clusterbits %u for nid %llu, please upgrade kernel",
vi->z_physical_clusterbits[0], vi->nid);
err = -ENOTSUPP;
err = -EOPNOTSUPP;
goto unmap_done;
}

Expand Down Expand Up @@ -211,7 +211,7 @@ static int unpack_compacted_index(struct z_erofs_maprecorder *m,
else if (1 << amortizedshift == 2 && lclusterbits == 12)
vcnt = 16;
else
return -ENOTSUPP;
return -EOPNOTSUPP;

encodebits = ((vcnt << amortizedshift) - sizeof(__le32)) * 8 / vcnt;
base = round_down(eofs, vcnt << amortizedshift);
Expand Down Expand Up @@ -275,7 +275,7 @@ static int compacted_load_cluster_from_disk(struct z_erofs_maprecorder *m,
int err;

if (lclusterbits != 12)
return -ENOTSUPP;
return -EOPNOTSUPP;

if (lcn >= totalidx)
return -EINVAL;
Expand Down

0 comments on commit ff784a7

Please sign in to comment.