Skip to content

Commit

Permalink
drivers/net/: all drivers/net/ cleanup with ARRAY_SIZE
Browse files Browse the repository at this point in the history
Signed-off-by: Denis Cheng <crquan@gmail.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
  • Loading branch information
Denis Cheng authored and David S. Miller committed Oct 10, 2007
1 parent 10d024c commit ff8ac60
Show file tree
Hide file tree
Showing 37 changed files with 70 additions and 78 deletions.
2 changes: 1 addition & 1 deletion drivers/net/apne.c
Original file line number Diff line number Diff line change
Expand Up @@ -246,7 +246,7 @@ static int __init apne_probe1(struct net_device *dev, int ioaddr)
{0x00, NE_EN0_RSARHI},
{E8390_RREAD+E8390_START, NE_CMD},
};
for (i = 0; i < sizeof(program_seq)/sizeof(program_seq[0]); i++) {
for (i = 0; i < ARRAY_SIZE(program_seq); i++) {
outb(program_seq[i].value, ioaddr + program_seq[i].offset);
}

Expand Down
2 changes: 1 addition & 1 deletion drivers/net/arm/am79c961a.c
Original file line number Diff line number Diff line change
Expand Up @@ -414,7 +414,7 @@ static void am79c961_setmulticastlist (struct net_device *dev)
/*
* Update the multicast hash table
*/
for (i = 0; i < sizeof(multi_hash) / sizeof(multi_hash[0]); i++)
for (i = 0; i < ARRAY_SIZE(multi_hash); i++)
write_rreg(dev->base_addr, i + LADRL, multi_hash[i]);

/*
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/atarilance.c
Original file line number Diff line number Diff line change
Expand Up @@ -263,7 +263,7 @@ struct lance_addr {
(highest byte stripped) */
};

#define N_LANCE_ADDR (sizeof(lance_addr_list)/sizeof(*lance_addr_list))
#define N_LANCE_ADDR ARRAY_SIZE(lance_addr_list)


/* Definitions for the Lance */
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/atl1/atl1_hw.c
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ static struct atl1_spi_flash_dev flash_table[] = {

static void atl1_init_flash_opcode(struct atl1_hw *hw)
{
if (hw->flash_vendor >= sizeof(flash_table) / sizeof(flash_table[0]))
if (hw->flash_vendor >= ARRAY_SIZE(flash_table))
hw->flash_vendor = 0; /* ATMEL */

/* Init OP table */
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/bnx2.c
Original file line number Diff line number Diff line change
Expand Up @@ -3492,7 +3492,7 @@ bnx2_init_nvram(struct bnx2 *bp)
/* Determine the selected interface. */
val = REG_RD(bp, BNX2_NVM_CFG1);

entry_count = sizeof(flash_table) / sizeof(struct flash_spec);
entry_count = ARRAY_SIZE(flash_table);

if (val & 0x40000000) {

Expand Down
6 changes: 3 additions & 3 deletions drivers/net/cs89x0.c
Original file line number Diff line number Diff line change
Expand Up @@ -805,7 +805,7 @@ cs89x0_probe1(struct net_device *dev, int ioaddr, int modular)
i = cs8900_irq_map[0];
#else
/* Translate the IRQ using the IRQ mapping table. */
if (i >= sizeof(cs8900_irq_map)/sizeof(cs8900_irq_map[0]))
if (i >= ARRAY_SIZE(cs8900_irq_map))
printk("\ncs89x0: invalid ISA interrupt number %d\n", i);
else
i = cs8900_irq_map[i];
Expand Down Expand Up @@ -1246,11 +1246,11 @@ write_irq(struct net_device *dev, int chip_type, int irq)

if (chip_type == CS8900) {
/* Search the mapping table for the corresponding IRQ pin. */
for (i = 0; i != sizeof(cs8900_irq_map)/sizeof(cs8900_irq_map[0]); i++)
for (i = 0; i != ARRAY_SIZE(cs8900_irq_map); i++)
if (cs8900_irq_map[i] == irq)
break;
/* Not found */
if (i == sizeof(cs8900_irq_map)/sizeof(cs8900_irq_map[0]))
if (i == ARRAY_SIZE(cs8900_irq_map))
i = 3;
writereg(dev, PP_CS8900_ISAINT, i);
} else {
Expand Down
3 changes: 1 addition & 2 deletions drivers/net/e1000/e1000_ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -106,8 +106,7 @@ static const struct e1000_stats e1000_gstrings_stats[] = {
};

#define E1000_QUEUE_STATS_LEN 0
#define E1000_GLOBAL_STATS_LEN \
sizeof(e1000_gstrings_stats) / sizeof(struct e1000_stats)
#define E1000_GLOBAL_STATS_LEN ARRAY_SIZE(e1000_gstrings_stats)
#define E1000_STATS_LEN (E1000_GLOBAL_STATS_LEN + E1000_QUEUE_STATS_LEN)
static const char e1000_gstrings_test[][ETH_GSTRING_LEN] = {
"Register test (offline)", "Eeprom test (offline)",
Expand Down
5 changes: 2 additions & 3 deletions drivers/net/fec_8xx/fec_mii.c
Original file line number Diff line number Diff line change
Expand Up @@ -308,12 +308,11 @@ int fec_mii_phy_id_detect(struct net_device *dev)
return -1;
}

for (i = 0, phy = phy_info; i < sizeof(phy_info) / sizeof(phy_info[0]);
i++, phy++)
for (i = 0, phy = phy_info; i < ARRAY_SIZE(phy_info); i++, phy++)
if (phy->id == (phy_hwid >> 4) || phy->id == 0)
break;

if (i >= sizeof(phy_info) / sizeof(phy_info[0])) {
if (i >= ARRAY_SIZE(phy_info)) {
printk(KERN_ERR DRV_MODULE_NAME
": %s PHY id 0x%08x is not supported!\n",
dev->name, phy_hwid);
Expand Down
8 changes: 4 additions & 4 deletions drivers/net/ibm_emac/ibm_emac_debug.c
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ void emac_dbg_register(int idx, struct ocp_enet_private *dev)
{
unsigned long flags;

if (idx >= sizeof(__emacs) / sizeof(__emacs[0])) {
if (idx >= ARRAY_SIZE(__emacs)) {
printk(KERN_WARNING
"invalid index %d when registering EMAC for debugging\n",
idx);
Expand All @@ -148,7 +148,7 @@ void mal_dbg_register(int idx, struct ibm_ocp_mal *mal)
{
unsigned long flags;

if (idx >= sizeof(__mals) / sizeof(__mals[0])) {
if (idx >= ARRAY_SIZE(__mals)) {
printk(KERN_WARNING
"invalid index %d when registering MAL for debugging\n",
idx);
Expand All @@ -167,11 +167,11 @@ void emac_dbg_dump_all(void)

local_irq_save(flags);

for (i = 0; i < sizeof(__mals) / sizeof(__mals[0]); ++i)
for (i = 0; i < ARRAY_SIZE(__mals); ++i)
if (__mals[i])
emac_mal_dump(__mals[i]);

for (i = 0; i < sizeof(__emacs) / sizeof(__emacs[0]); ++i)
for (i = 0; i < ARRAY_SIZE(__emacs); ++i)
if (__emacs[i])
emac_mac_dump(i, __emacs[i]);

Expand Down
2 changes: 1 addition & 1 deletion drivers/net/irda/actisys-sir.c
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ static int actisys_reset(struct sir_dev *);
/* Note : the 220L doesn't support 38400, but we will fix that below */
static unsigned baud_rates[] = { 9600, 19200, 57600, 115200, 38400 };

#define MAX_SPEEDS (sizeof(baud_rates)/sizeof(baud_rates[0]))
#define MAX_SPEEDS ARRAY_SIZE(baud_rates)

static struct dongle_driver act220l = {
.owner = THIS_MODULE,
Expand Down
3 changes: 1 addition & 2 deletions drivers/net/ixgb/ixgb_ethtool.c
Original file line number Diff line number Diff line change
Expand Up @@ -94,8 +94,7 @@ static struct ixgb_stats ixgb_gstrings_stats[] = {
{"tx_csum_offload_errors", IXGB_STAT(hw_csum_tx_error)}
};

#define IXGB_STATS_LEN \
sizeof(ixgb_gstrings_stats) / sizeof(struct ixgb_stats)
#define IXGB_STATS_LEN ARRAY_SIZE(ixgb_gstrings_stats)

static int
ixgb_get_settings(struct net_device *netdev, struct ethtool_cmd *ecmd)
Expand Down
4 changes: 1 addition & 3 deletions drivers/net/lp486e.c
Original file line number Diff line number Diff line change
Expand Up @@ -515,8 +515,6 @@ CLEAR_INT(void) {
outb(0, IOADDR+8);
}

#define SIZE(x) (sizeof(x)/sizeof((x)[0]))

#if 0
/* selftest or dump */
static void
Expand All @@ -532,7 +530,7 @@ i596_port_do(struct net_device *dev, int portcmd, char *cmdname) {
mdelay(30); /* random, unmotivated */

printk("lp486e i82596 %s result:\n", cmdname);
for (m = SIZE(lp->dump.dump); m && lp->dump.dump[m-1] == 0; m--)
for (m = ARRAY_SIZE(lp->dump.dump); m && lp->dump.dump[m-1] == 0; m--)
;
for (i = 0; i < m; i++) {
printk(" %04x", lp->dump.dump[i]);
Expand Down
3 changes: 1 addition & 2 deletions drivers/net/mv643xx_eth.c
Original file line number Diff line number Diff line change
Expand Up @@ -2680,8 +2680,7 @@ static const struct mv643xx_stats mv643xx_gstrings_stats[] = {
{ "late_collision", MV643XX_STAT(mib_counters.late_collision) },
};

#define MV643XX_STATS_LEN \
sizeof(mv643xx_gstrings_stats) / sizeof(struct mv643xx_stats)
#define MV643XX_STATS_LEN ARRAY_SIZE(mv643xx_gstrings_stats)

static void mv643xx_get_drvinfo(struct net_device *netdev,
struct ethtool_drvinfo *drvinfo)
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/ne-h8300.c
Original file line number Diff line number Diff line change
Expand Up @@ -257,7 +257,7 @@ static int __init ne_probe1(struct net_device *dev, int ioaddr)
{E8390_RREAD+E8390_START, E8390_CMD},
};

for (i = 0; i < sizeof(program_seq)/sizeof(program_seq[0]); i++)
for (i = 0; i < ARRAY_SIZE(program_seq); i++)
outb_p(program_seq[i].value, ioaddr + program_seq[i].offset);

}
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/ne.c
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,7 @@ static int __init ne_probe1(struct net_device *dev, unsigned long ioaddr)
{E8390_RREAD+E8390_START, E8390_CMD},
};

for (i = 0; i < sizeof(program_seq)/sizeof(program_seq[0]); i++)
for (i = 0; i < ARRAY_SIZE(program_seq); i++)
outb_p(program_seq[i].value, ioaddr + program_seq[i].offset);

}
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/ne2.c
Original file line number Diff line number Diff line change
Expand Up @@ -430,7 +430,7 @@ static int __init ne2_probe1(struct net_device *dev, int slot)
{E8390_RREAD+E8390_START, E8390_CMD},
};

for (i = 0; i < sizeof(program_seq)/sizeof(program_seq[0]); i++)
for (i = 0; i < ARRAY_SIZE(program_seq); i++)
outb_p(program_seq[i].value, base_addr +
program_seq[i].offset);

Expand Down
2 changes: 1 addition & 1 deletion drivers/net/ne2k-pci.c
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ static int __devinit ne2k_pci_init_one (struct pci_dev *pdev,
{0x00, EN0_RSARHI},
{E8390_RREAD+E8390_START, E8390_CMD},
};
for (i = 0; i < sizeof(program_seq)/sizeof(program_seq[0]); i++)
for (i = 0; i < ARRAY_SIZE(program_seq); i++)
outb(program_seq[i].value, ioaddr + program_seq[i].offset);

}
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/netxen/netxen_nic.h
Original file line number Diff line number Diff line change
Expand Up @@ -1119,7 +1119,7 @@ static const struct netxen_brdinfo netxen_boards[] = {
{NETXEN_BRDTYPE_P2_SB31_2G, 2, "Dual Gb"},
};

#define NUM_SUPPORTED_BOARDS (sizeof(netxen_boards)/sizeof(struct netxen_brdinfo))
#define NUM_SUPPORTED_BOARDS ARRAY_SIZE(netxen_boards)

static inline void get_brd_port_by_type(u32 type, int *ports)
{
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/netxen/netxen_nic_hw.c
Original file line number Diff line number Diff line change
Expand Up @@ -569,7 +569,7 @@ int netxen_is_flash_supported(struct netxen_adapter *adapter)
/* if the flash size less than 4Mb, make huge war cry and die */
for (j = 1; j < 4; j++) {
addr = j * NETXEN_NIC_WINDOW_MARGIN;
for (i = 0; i < (sizeof(locs) / sizeof(locs[0])); i++) {
for (i = 0; i < ARRAY_SIZE(locs); i++) {
if (netxen_rom_fast_read(adapter, locs[i], &val01) == 0
&& netxen_rom_fast_read(adapter, (addr + locs[i]),
&val02) == 0) {
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/pcmcia/axnet_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ static int get_prom(struct pcmcia_device *link)
axnet_reset_8390(dev);
mdelay(10);

for (i = 0; i < sizeof(program_seq)/sizeof(program_seq[0]); i++)
for (i = 0; i < ARRAY_SIZE(program_seq); i++)
outb_p(program_seq[i].value, ioaddr + program_seq[i].offset);

for (i = 0; i < 6; i += 2) {
Expand Down
4 changes: 2 additions & 2 deletions drivers/net/pcmcia/pcnet_cs.c
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ static hw_info_t hw_info[] = {
{ /* PCMCIA Technology OEM */ 0x01c8, 0x00, 0xa0, 0x0c, 0 }
};

#define NR_INFO (sizeof(hw_info)/sizeof(hw_info_t))
#define NR_INFO ARRAY_SIZE(hw_info)

static hw_info_t default_info = { 0, 0, 0, 0, 0 };
static hw_info_t dl10019_info = { 0, 0, 0, 0, IS_DL10019|HAS_MII };
Expand Down Expand Up @@ -374,7 +374,7 @@ static hw_info_t *get_prom(struct pcmcia_device *link)
pcnet_reset_8390(dev);
mdelay(10);

for (i = 0; i < sizeof(program_seq)/sizeof(program_seq[0]); i++)
for (i = 0; i < ARRAY_SIZE(program_seq); i++)
outb_p(program_seq[i].value, ioaddr + program_seq[i].offset);

for (i = 0; i < 32; i++)
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/phy/phy.c
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ static const struct phy_setting settings[] = {
},
};

#define MAX_NUM_SETTINGS (sizeof(settings)/sizeof(struct phy_setting))
#define MAX_NUM_SETTINGS ARRAY_SIZE(settings)

/**
* phy_find_setting - find a PHY settings array entry that matches speed & duplex
Expand Down
2 changes: 1 addition & 1 deletion drivers/net/skfp/smt.c
Original file line number Diff line number Diff line change
Expand Up @@ -1654,7 +1654,7 @@ static const struct smt_pdef {
{ SMT_P4053, 0, SWAP_SMT_P4053 } ,
} ;

#define N_SMT_PLEN (sizeof(smt_pdef)/sizeof(smt_pdef[0]))
#define N_SMT_PLEN ARRAY_SIZE(smt_pdef)

int smt_check_para(struct s_smc *smc, struct smt_header *sm,
const u_short list[])
Expand Down
4 changes: 2 additions & 2 deletions drivers/net/skfp/srf.c
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ static void clear_reported(struct s_smc *smc);
static void smt_send_srf(struct s_smc *smc);
static struct s_srf_evc *smt_get_evc(struct s_smc *smc, int code, int index);

#define MAX_EVCS (sizeof(smc->evcs)/sizeof(smc->evcs[0]))
#define MAX_EVCS ARRAY_SIZE(smc->evcs)

struct evc_init {
u_char code ;
Expand All @@ -67,7 +67,7 @@ static const struct evc_init evc_inits[] = {
{ SMT_EVENT_PORT_PATH_CHANGE, INDEX_PORT,NUMPHYS,SMT_P4053 } ,
} ;

#define MAX_INIT_EVC (sizeof(evc_inits)/sizeof(evc_inits[0]))
#define MAX_INIT_EVC ARRAY_SIZE(evc_inits)

void smt_init_evc(struct s_smc *smc)
{
Expand Down
6 changes: 3 additions & 3 deletions drivers/net/tulip/de4x5.c
Original file line number Diff line number Diff line change
Expand Up @@ -3945,7 +3945,7 @@ create_packet(struct net_device *dev, char *frame, int len)
static int
EISA_signature(char *name, struct device *device)
{
int i, status = 0, siglen = sizeof(de4x5_signatures)/sizeof(c_char *);
int i, status = 0, siglen = ARRAY_SIZE(de4x5_signatures);
struct eisa_device *edev;

*name = '\0';
Expand All @@ -3966,7 +3966,7 @@ EISA_signature(char *name, struct device *device)
static int
PCI_signature(char *name, struct de4x5_private *lp)
{
int i, status = 0, siglen = sizeof(de4x5_signatures)/sizeof(c_char *);
int i, status = 0, siglen = ARRAY_SIZE(de4x5_signatures);

if (lp->chipset == DC21040) {
strcpy(name, "DE434/5");
Expand Down Expand Up @@ -5072,7 +5072,7 @@ mii_get_phy(struct net_device *dev)
{
struct de4x5_private *lp = netdev_priv(dev);
u_long iobase = dev->base_addr;
int i, j, k, n, limit=sizeof(phy_info)/sizeof(struct phy_table);
int i, j, k, n, limit=ARRAY_SIZE(phy_info);
int id;

lp->active = 0;
Expand Down
6 changes: 3 additions & 3 deletions drivers/net/wireless/airo.c
Original file line number Diff line number Diff line change
Expand Up @@ -7578,9 +7578,9 @@ static const iw_handler airo_private_handler[] =

static const struct iw_handler_def airo_handler_def =
{
.num_standard = sizeof(airo_handler)/sizeof(iw_handler),
.num_private = sizeof(airo_private_handler)/sizeof(iw_handler),
.num_private_args = sizeof(airo_private_args)/sizeof(struct iw_priv_args),
.num_standard = ARRAY_SIZE(airo_handler),
.num_private = ARRAY_SIZE(airo_private_handler),
.num_private_args = ARRAY_SIZE(airo_private_args),
.standard = airo_handler,
.private = airo_private_handler,
.private_args = airo_private_args,
Expand Down
6 changes: 3 additions & 3 deletions drivers/net/wireless/hostap/hostap_ioctl.c
Original file line number Diff line number Diff line change
Expand Up @@ -3976,9 +3976,9 @@ static const iw_handler prism2_private_handler[] =

const struct iw_handler_def hostap_iw_handler_def =
{
.num_standard = sizeof(prism2_handler) / sizeof(iw_handler),
.num_private = sizeof(prism2_private_handler) / sizeof(iw_handler),
.num_private_args = sizeof(prism2_priv) / sizeof(struct iw_priv_args),
.num_standard = ARRAY_SIZE(prism2_handler),
.num_private = ARRAY_SIZE(prism2_private_handler),
.num_private_args = ARRAY_SIZE(prism2_priv),
.standard = (iw_handler *) prism2_handler,
.private = (iw_handler *) prism2_private_handler,
.private_args = (struct iw_priv_args *) prism2_priv,
Expand Down
7 changes: 3 additions & 4 deletions drivers/net/wireless/ipw2100.c
Original file line number Diff line number Diff line change
Expand Up @@ -8277,10 +8277,9 @@ static struct iw_statistics *ipw2100_wx_wireless_stats(struct net_device *dev)

static struct iw_handler_def ipw2100_wx_handler_def = {
.standard = ipw2100_wx_handlers,
.num_standard = sizeof(ipw2100_wx_handlers) / sizeof(iw_handler),
.num_private = sizeof(ipw2100_private_handler) / sizeof(iw_handler),
.num_private_args = sizeof(ipw2100_private_args) /
sizeof(struct iw_priv_args),
.num_standard = ARRAY_SIZE(ipw2100_wx_handlers),
.num_private = ARRAY_SIZE(ipw2100_private_handler),
.num_private_args = ARRAY_SIZE(ipw2100_private_args),
.private = (iw_handler *) ipw2100_private_handler,
.private_args = (struct iw_priv_args *)ipw2100_private_args,
.get_wireless_stats = ipw2100_wx_wireless_stats,
Expand Down
14 changes: 7 additions & 7 deletions drivers/net/wireless/libertas/main.c
Original file line number Diff line number Diff line change
Expand Up @@ -123,28 +123,28 @@ struct region_cfp_table {
static struct region_cfp_table region_cfp_table[] = {
{0x10, /*US FCC */
channel_freq_power_US_BG,
sizeof(channel_freq_power_US_BG) / sizeof(struct chan_freq_power),
ARRAY_SIZE(channel_freq_power_US_BG),
}
,
{0x20, /*CANADA IC */
channel_freq_power_US_BG,
sizeof(channel_freq_power_US_BG) / sizeof(struct chan_freq_power),
ARRAY_SIZE(channel_freq_power_US_BG),
}
,
{0x30, /*EU*/ channel_freq_power_EU_BG,
sizeof(channel_freq_power_EU_BG) / sizeof(struct chan_freq_power),
ARRAY_SIZE(channel_freq_power_EU_BG),
}
,
{0x31, /*SPAIN*/ channel_freq_power_SPN_BG,
sizeof(channel_freq_power_SPN_BG) / sizeof(struct chan_freq_power),
ARRAY_SIZE(channel_freq_power_SPN_BG),
}
,
{0x32, /*FRANCE*/ channel_freq_power_FR_BG,
sizeof(channel_freq_power_FR_BG) / sizeof(struct chan_freq_power),
ARRAY_SIZE(channel_freq_power_FR_BG),
}
,
{0x40, /*JAPAN*/ channel_freq_power_JPN_BG,
sizeof(channel_freq_power_JPN_BG) / sizeof(struct chan_freq_power),
ARRAY_SIZE(channel_freq_power_JPN_BG),
}
,
/*Add new region here */
Expand Down Expand Up @@ -1422,7 +1422,7 @@ struct chan_freq_power *libertas_get_region_cfp_table(u8 region, u8 band, int *c

lbs_deb_enter(LBS_DEB_MAIN);

end = sizeof(region_cfp_table)/sizeof(struct region_cfp_table);
end = ARRAY_SIZE(region_cfp_table);

for (i = 0; i < end ; i++) {
lbs_deb_main("region_cfp_table[i].region=%d\n",
Expand Down
Loading

0 comments on commit ff8ac60

Please sign in to comment.