Skip to content

Commit

Permalink
netdevice: add the case if dev is NULL
Browse files Browse the repository at this point in the history
commit b37a466 upstream.

Add the case if dev is NULL in dev_{put, hold}, so the caller doesn't
need to care whether dev is NULL or not.

Signed-off-by: Yajun Deng <yajun.deng@linux.dev>
Signed-off-by: David S. Miller <davem@davemloft.net>
Cc: Pavel Machek <pavel@denx.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
  • Loading branch information
Yajun Deng authored and Greg Kroah-Hartman committed Apr 8, 2022
1 parent c4dc584 commit ff919a7
Showing 1 changed file with 4 additions and 2 deletions.
6 changes: 4 additions & 2 deletions include/linux/netdevice.h
Original file line number Diff line number Diff line change
Expand Up @@ -3980,7 +3980,8 @@ void netdev_run_todo(void);
*/
static inline void dev_put(struct net_device *dev)
{
this_cpu_dec(*dev->pcpu_refcnt);
if (dev)
this_cpu_dec(*dev->pcpu_refcnt);
}

/**
Expand All @@ -3991,7 +3992,8 @@ static inline void dev_put(struct net_device *dev)
*/
static inline void dev_hold(struct net_device *dev)
{
this_cpu_inc(*dev->pcpu_refcnt);
if (dev)
this_cpu_inc(*dev->pcpu_refcnt);
}

/* Carrier loss detection, dial on demand. The functions netif_carrier_on
Expand Down

0 comments on commit ff919a7

Please sign in to comment.