Skip to content

Commit

Permalink
net: phy: micrel: fix interrupt handling
Browse files Browse the repository at this point in the history
After migration to the shared interrupt support, the KSZ8031 PHY with
enabled interrupt support was not able to notify about link status
change.

Fixes: 59ca4e5 ("net: phy: micrel: implement generic .handle_interrupt() callback")
Signed-off-by: Oleksij Rempel <o.rempel@pengutronix.de>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Link: https://lore.kernel.org/r/20201127123621.31234-1-o.rempel@pengutronix.de
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
  • Loading branch information
Oleksij Rempel authored and Jakub Kicinski committed Nov 28, 2020
1 parent 35c5841 commit fff4c74
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion drivers/net/phy/micrel.c
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ static irqreturn_t kszphy_handle_interrupt(struct phy_device *phydev)
return IRQ_NONE;
}

if ((irq_status & KSZPHY_INTCS_STATUS))
if (!(irq_status & KSZPHY_INTCS_STATUS))
return IRQ_NONE;

phy_trigger_machine(phydev);
Expand Down

0 comments on commit fff4c74

Please sign in to comment.