{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":1,"defaultBranch":"master","name":"mxq","ownerLogin":"mariux64","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-02-27T12:47:38.000Z","ownerAvatar":"https://github.molgen.mpg.de/avatars/u/7","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1708184643.0","currentOid":""},"activityList":{"items":[{"before":"646c815161fc16d8d7f07830a5e5254fc86aa008","after":"c2a33f83bfc6fe8f5ff7c644d0fdc04802a50416","ref":"refs/heads/master","pushedAt":"2024-02-17T15:35:49.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"Makefile: Update version to 0.31.2","shortMessageHtmlLink":"Makefile: Update version to 0.31.2"}},{"before":"914e50d319f553bfe6aa667f339af314a0b3be95","after":"646c815161fc16d8d7f07830a5e5254fc86aa008","ref":"refs/heads/master","pushedAt":"2024-02-17T15:31:06.000Z","pushType":"pr_merge","commitsCount":25,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"Merge pull request #151 from mariux64/next\n\nnext","shortMessageHtmlLink":"Merge pull request #151 from mariux64/next"}},{"before":"13af1cc9e97927e1f2adfb9880098c44a488e6d0","after":"98cf93c4ccf8203eee7fafcdfe736c261726cb11","ref":"refs/heads/next","pushedAt":"2024-02-17T15:30:47.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mysql: Restore column group_flags\n\nCommit d25a77e (\"mxq_job: Remove unused job_flags column\") accidentally\nremoved group_flags together with job_flags from the create_tables.sql\nfile. Undo.","shortMessageHtmlLink":"mysql: Restore column group_flags"}},{"before":"090544d8f9836463cf6d1eb6d296a12f593ef79e","after":"13af1cc9e97927e1f2adfb9880098c44a488e6d0","ref":"refs/heads/next","pushedAt":"2024-02-17T15:20:51.000Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mysql: Restore column group_flags\n\nCommit d25a77e (\"mxq_job: Remove unused job_flags column\") accidentally\nremoved group_flags together with job_flags from the create_tables.sql\nfile. Undo.","shortMessageHtmlLink":"mysql: Restore column group_flags"}},{"before":"f90a608025d7a225c80ba6355f3d2cc63f64fedc","after":"090544d8f9836463cf6d1eb6d296a12f593ef79e","ref":"refs/heads/next","pushedAt":"2024-01-15T10:58:02.618Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mysql: Restore column group_flags\n\nCommit d25a77e (\"mxq_job: Remove unused job_flags column\") accidentally\nremoved group_flags together with job_flags from the create_tables.sql\nfile. Undo.","shortMessageHtmlLink":"mysql: Restore column group_flags"}},{"before":"70a00894e1a7988ef4aaaaf99bfe3c7121e752ac","after":"f90a608025d7a225c80ba6355f3d2cc63f64fedc","ref":"refs/heads/next","pushedAt":"2024-01-10T17:05:26.956Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mxqkill: Update usage string","shortMessageHtmlLink":"mxqkill: Update usage string"}},{"before":"c77eb3ed7f45e6db90ba13e55e0c75415e369969","after":"70a00894e1a7988ef4aaaaf99bfe3c7121e752ac","ref":"refs/heads/next","pushedAt":"2024-01-10T16:53:04.809Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mx_util: Fix calloc argument order","shortMessageHtmlLink":"mx_util: Fix calloc argument order"}},{"before":"c7f57d88a00c0c249615ec188217a157d9d5c479","after":"c77eb3ed7f45e6db90ba13e55e0c75415e369969","ref":"refs/heads/next","pushedAt":"2024-01-10T16:19:11.043Z","pushType":"push","commitsCount":9,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mx_util: Fix calloc argument order","shortMessageHtmlLink":"mx_util: Fix calloc argument order"}},{"before":"f08314c80041b5058dbfeb880191166b70c3b675","after":"c7f57d88a00c0c249615ec188217a157d9d5c479","ref":"refs/heads/next","pushedAt":"2024-01-10T09:06:27.018Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mxqsub: Remove default time warning\n\nRemove the warning for the default runtime option in mxqsub. Users found\nthe message \"option '--runtime' or '-t' not used. Your job will get\nkilled if it runs longer than the default of 15 minutes\" annoying,\nespecially as there's no equivalent warning for the default memory\nlimit.","shortMessageHtmlLink":"mxqsub: Remove default time warning"}},{"before":"37d0eee99b24880efb025db304ed54a05a544c46","after":"f08314c80041b5058dbfeb880191166b70c3b675","ref":"refs/heads/next","pushedAt":"2024-01-10T08:52:31.094Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mx_getopt: Remove a NULL pointer check\n\nThe only caller of the static find_short_option() function doesn't calls\nit with a NULL pointer value as the third argument:\n\n idx = find_short_option(optctl->options, &optctl->_unhandled_shortopts, &optctl->optarg);\n\nSo it is not necessary for the function to check the pointer for NULL.\n\nThe disadvantage of doing is, that the llvm static analyzer concludes\nfrom the check, that it was possible that the function would be called\nwith a NULL pointer and questiones a later access in the same function,\nwhich is unchecked:\n\n mx_getopt.c:158:16: warning: Dereference of null pointer (loaded from variable 'optarg') [core.NullDereference]\n *optarg = *name;\n ~~~~~~ ^\n 1 warning generated.\n\nRemove the check.","shortMessageHtmlLink":"mx_getopt: Remove a NULL pointer check"}},{"before":"cd68e5cb22f07e8a9f8735263c416411798613ee","after":"914e50d319f553bfe6aa667f339af314a0b3be95","ref":"refs/heads/master","pushedAt":"2024-01-08T17:33:43.080Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"Makefile: Update version to 0.31.1","shortMessageHtmlLink":"Makefile: Update version to 0.31.1"}},{"before":"c69f93ab7ac47de3a8abcf2dbf1a2098701cde57","after":"125502303389a80d6011529f1b915000b67fdcee","ref":"refs/heads/fix-154","pushedAt":"2024-01-08T17:33:06.813Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mxqkill: Correct job counts for cancelled groups\n\nCommit 22aadf3b87583 (\"sql: Implement mx_update_job2 trigger\")\neliminated the `INQ`->`CANCELLED` housekeeping trigger, claiming that\nthe job state is no longer set to `CANCELLED` by code.\n\nThis is incorrect, as update_job_status_cancelled_by_group() still sets\nthe job status to `CANCELLED` when a group is cancelled.\n\nModify update_job_status_cancelled_by_group() to set the `job_cancelled`\nflag instead of the `job_status`. Leave the job status transition to the\ntrigger.\n\nExclude `ASSIGNED` jobs, as the daemon handles them. Also, remove\nunnecessary checks for unset `host_hostname`, `server_id`, and\n`host_pid`.","shortMessageHtmlLink":"mxqkill: Correct job counts for cancelled groups"}},{"before":"125502303389a80d6011529f1b915000b67fdcee","after":"c69f93ab7ac47de3a8abcf2dbf1a2098701cde57","ref":"refs/heads/fix-154","pushedAt":"2024-01-08T17:31:48.345Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"Makefile: Update version to 0.31.1","shortMessageHtmlLink":"Makefile: Update version to 0.31.1"}},{"before":"9dda8092edb56c7f1189d75767a688564b77123a","after":"cd68e5cb22f07e8a9f8735263c416411798613ee","ref":"refs/heads/master","pushedAt":"2024-01-08T17:30:28.902Z","pushType":"pr_merge","commitsCount":2,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"Merge pull request #155 from mariux64/fix-154\n\nmxqkill: Correct job counts for cancelled groups","shortMessageHtmlLink":"Merge pull request #155 from mariux64/fix-154"}},{"before":null,"after":"125502303389a80d6011529f1b915000b67fdcee","ref":"refs/heads/fix-154","pushedAt":"2024-01-08T17:28:44.965Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mxqkill: Correct job counts for cancelled groups\n\nCommit 22aadf3b87583 (\"sql: Implement mx_update_job2 trigger\")\neliminated the `INQ`->`CANCELLED` housekeeping trigger, claiming that\nthe job state is no longer set to `CANCELLED` by code.\n\nThis is incorrect, as update_job_status_cancelled_by_group() still sets\nthe job status to `CANCELLED` when a group is cancelled.\n\nModify update_job_status_cancelled_by_group() to set the `job_cancelled`\nflag instead of the `job_status`. Leave the job status transition to the\ntrigger.\n\nExclude `ASSIGNED` jobs, as the daemon handles them. Also, remove\nunnecessary checks for unset `host_hostname`, `server_id`, and\n`host_pid`.","shortMessageHtmlLink":"mxqkill: Correct job counts for cancelled groups"}},{"before":"1eea3695036eb12daf24de5b762bbf08e7ae7a67","after":"37d0eee99b24880efb025db304ed54a05a544c46","ref":"refs/heads/next","pushedAt":"2024-01-05T13:08:09.345Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mx_getopt: Remove a NULL pointer check\n\nThe only caller of the static find_short_option() function doesn't calls\nit with a NULL pointer value as the third argument:\n\n idx = find_short_option(optctl->options, &optctl->_unhandled_shortopts, &optctl->optarg);\n\nSo it is not necessary for the function to check the pointer for NULL.\n\nThe disadvantage of doing is, that the llvm static analyzer concludes\nfrom the check, that it was possible that the function would be called\nwith a NULL pointer and questiones a later access in the same function,\nwhich is unchecked:\n\n mx_getopt.c:158:16: warning: Dereference of null pointer (loaded from variable 'optarg') [core.NullDereference]\n *optarg = *name;\n ~~~~~~ ^\n 1 warning generated.\n\nRemove the check.","shortMessageHtmlLink":"mx_getopt: Remove a NULL pointer check"}},{"before":"803ce93e8ba3801f52b8a1e6d9fbaf562190edd2","after":"1eea3695036eb12daf24de5b762bbf08e7ae7a67","ref":"refs/heads/next","pushedAt":"2024-01-05T08:43:17.180Z","pushType":"push","commitsCount":2,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mx_mysql: mx_mysql_statement_close*: Allow NULL\n\nAllow mx_mysql_statement_close* functions to be called with a pointer to\na NULL value. This makes the daemon more robust when the functions are\nused as cleanup functions, e.g.\n\n __attribute__((cleanup(mx_mysql_statement_close)))\n struct mx_mysql_stmt *stmt = mx_mysql_statement_prepare(mysql,\"...\");\n if (!stmt) {\n fprintf(stderr, \"mx_mysql_stmt_prepare: %s\\n\", mx_mysql_error());\n return;\n }","shortMessageHtmlLink":"mx_mysql: mx_mysql_statement_close*: Allow NULL"}},{"before":"757704b2266501414088ff5fb35804c8ed386905","after":"803ce93e8ba3801f52b8a1e6d9fbaf562190edd2","ref":"refs/heads/next","pushedAt":"2024-01-02T15:08:19.744Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"sql: Create indexes on group_jobs_inq and group_jobs_running\n\nA select on `(group_jobs_inq > 0 OR group_jobs_running > 0)` is done in\nthe main loop on each daemon. Add two indexes to drastically reduce the\nload on the MySQL server.","shortMessageHtmlLink":"sql: Create indexes on group_jobs_inq and group_jobs_running"}},{"before":"d913d720f5ca93b8bb92abf25ce3075ee95ab7e9","after":"757704b2266501414088ff5fb35804c8ed386905","ref":"refs/heads/next","pushedAt":"2024-01-01T14:54:20.756Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"sql: create_tables: Add default character set to tables\n\nAdd default characer set option to the mxq tables, so that we don't\ndepend on the default character set of the databser or the server.","shortMessageHtmlLink":"sql: create_tables: Add default character set to tables"}},{"before":"74488bca0d6c79994f8bd990ac0f6dc4bbecf634","after":"d913d720f5ca93b8bb92abf25ce3075ee95ab7e9","ref":"refs/heads/next","pushedAt":"2024-01-01T14:22:48.636Z","pushType":"push","commitsCount":2,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mxq_reaper: Retry on spool file write errors\n\nIf we can't write the spool file for any reason, do not write to stderr,\nas this is the users stderr of the mxq job. Just wait and retry until\nsuccess.","shortMessageHtmlLink":"mxq_reaper: Retry on spool file write errors"}},{"before":"bf8238b7053081c4de620e2b8950a00387b01d12","after":"74488bca0d6c79994f8bd990ac0f6dc4bbecf634","ref":"refs/heads/next","pushedAt":"2024-01-01T13:38:16.917Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"Makefile: Disable warning for Bison-generated source\n\nBison-3.4.2 together with llvm 15.0.4 produce the warning\n\n parser.tab.c:1078:9: warning: variable 'yynerrs' set but not used\n\nDisable this warning for the parser.tab.c compilation.","shortMessageHtmlLink":"Makefile: Disable warning for Bison-generated source"}},{"before":"009304f03b38d57b2c26c24e53b4f9c86121c738","after":"bf8238b7053081c4de620e2b8950a00387b01d12","ref":"refs/heads/next","pushedAt":"2024-01-01T13:37:09.590Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"Makefile: Disable warning for Bison-generated source\n\nBison-3.4.2 together with llvm 15.0.4 produce the warning\n\n parser.tab.c:1078:9: warning: variable 'yynerrs' set but not used\n\nDisable this warning for the parser.tab.c compilation.","shortMessageHtmlLink":"Makefile: Disable warning for Bison-generated source"}},{"before":"aa03e452a03a1349b3b21a40b6786fef9e535af7","after":"009304f03b38d57b2c26c24e53b4f9c86121c738","ref":"refs/heads/next","pushedAt":"2023-12-30T12:33:15.714Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"gpu-setup: Don't unlock to early during release\n\nCurrently, the gpu lock file `pid` is released (removed) to early, so\nthat there is a small race condition with a new GPU allocation:\n\n```\n MXQ job1 job2\n* fork job1\n * other initialization\n * reserve gpu:\n * * find slot without pid\n * * change access to UID\n * run user program\n * exit\n* fork job2\n * other initialization\n* cleanup job 1:\n* * rm .../pid\n * reserve gpu:\n * * find slot without pid\n * * change access to UID\n* * change access to root\n```\n\nOn release, keep the `pid` file until after the access mode has been\nchanged back to root.","shortMessageHtmlLink":"gpu-setup: Don't unlock to early during release"}},{"before":"b7210b61b19b3c6b76e3faf5add149998a2d381a","after":"aa03e452a03a1349b3b21a40b6786fef9e535af7","ref":"refs/heads/next","pushedAt":"2023-12-30T12:20:08.773Z","pushType":"push","commitsCount":2,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"Merge branch 'add-gpu-alloc-debug' into next\n\n* add-gpu-alloc-debug:\n gpu-setup: Add some temporary debug messages","shortMessageHtmlLink":"Merge branch 'add-gpu-alloc-debug' into next"}},{"before":"70a5acc607ee4b333a898587705a7ebebb35859b","after":"b7210b61b19b3c6b76e3faf5add149998a2d381a","ref":"refs/heads/next","pushedAt":"2023-12-30T12:15:38.640Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"gpu-setup: Improve error message","shortMessageHtmlLink":"gpu-setup: Improve error message"}},{"before":"48746e89e7d99986fba6e577104bb16e79c8e3a3","after":"9dda8092edb56c7f1189d75767a688564b77123a","ref":"refs/heads/master","pushedAt":"2023-12-30T12:03:24.385Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mxq_daemon: Fix usage of uninitialized variable\n\nFixes: 51259a9001aa (\"mx_mysql: Refactor bind functions to void\")","shortMessageHtmlLink":"mxq_daemon: Fix usage of uninitialized variable"}},{"before":null,"after":"70a5acc607ee4b333a898587705a7ebebb35859b","ref":"refs/heads/next","pushedAt":"2023-12-30T10:33:32.316Z","pushType":"branch_creation","commitsCount":0,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"mxqsub: Don't fail with --umask 000","shortMessageHtmlLink":"mxqsub: Don't fail with --umask 000"}},{"before":"a6a1cece2f446b995cd89f8542de32b9a383d64b","after":"48746e89e7d99986fba6e577104bb16e79c8e3a3","ref":"refs/heads/master","pushedAt":"2023-12-29T22:03:15.105Z","pushType":"force_push","commitsCount":0,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"sql: Change trigger syntax for MySQL 5 database\n\nThe syntax for multiple triggers for the same event and table works for\nMySQL 8 databases but is not accepted for MySQL 5 databases.\n\nRefactor the statements from the `mxq_udpate_job2` trigger into the\n`mxq_update_job`trigger.","shortMessageHtmlLink":"sql: Change trigger syntax for MySQL 5 database"}},{"before":"7bfcc381e882e7a0057cfd9b03e7005ad5aae875","after":"a6a1cece2f446b995cd89f8542de32b9a383d64b","ref":"refs/heads/master","pushedAt":"2023-12-29T21:33:50.625Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"sql: Change trigger syntax for MySQL 5 database\n\nThe syntax for multiple triggers for the same even and table works for\nMySQL 8 databases but is not accepted for MySQL 5 databases.\n\nRefactor the statements from the `mxq_udpate_job2` trigger into the\n`mxq_update_job`trigger.","shortMessageHtmlLink":"sql: Change trigger syntax for MySQL 5 database"}},{"before":"0ee8cc7da9e8f9014d9c940eabf5e9f7393ddc64","after":"7bfcc381e882e7a0057cfd9b03e7005ad5aae875","ref":"refs/heads/master","pushedAt":"2023-12-29T15:38:51.428Z","pushType":"push","commitsCount":1,"pusher":{"login":"donald","name":"Donald Buczek","path":"/donald","primaryAvatarUrl":"https://github.molgen.mpg.de/avatars/u/5?s=80"},"commit":{"message":"Makefile: Update version to 0.31.0","shortMessageHtmlLink":"Makefile: Update version to 0.31.0"}}],"hasNextPage":true,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks4AAlPMAA","startCursor":null,"endCursor":null}},"title":"Activity ยท mariux64/mxq"}