Skip to content

mxqsub: Rethink if 'WARNING: option '--runtime' or '-t' not used. Your job will...' really makes sense #146

Closed
thomas opened this issue Sep 11, 2023 · 4 comments · Fixed by #151

Comments

@thomas
Copy link
Contributor

thomas commented Sep 11, 2023

The message:

WARNING: option '--runtime' or '-t' not used. Your job will get killed if it runs longer than the default of 15 minutes.

flashes up everytime when mxqsub is called. This is IMHO meaningless and on the long run just disturbing.

So either I'm forced to use -t to get rid of the warning (but then -t should be mandatory?) or I must bear this noise for ever?

Also it is way inconsequent, beeing in this sense, why not also have a warning like:

WARNING: option '--memory' or '-m' not used. Your job ...

So I propose to remove

mxq/mxqsub.c

Line 1057 in f3d9fb8

mx_log_warning("option '--runtime' or '-t' not used. Your job will get killed if it runs longer than the default of %d minutes.", arg_time);

@donald
Copy link
Contributor

donald commented Dec 30, 2023

If we make -tmandatory, we'd break existing scripts. Just remove the warning? OTOH, if user doesn't want to see the message, it could be switched off easily with -t 15m. And for first-time users, a job getting killed after 15 minutes might be a negative surprise. Opinions?

@thomas
Copy link
Contributor Author

thomas commented Jan 9, 2024

A job that exceeds the memory limit (just 2G ...) will also be a surprise for first-timers, so I can not fully agree why runtime gets an exception. Or what about an environment variable or a ~/.mxq_defaults file. Then I set it once, and can work on with mxqsub without noise?

@donald
Copy link
Contributor

donald commented Jan 9, 2024

I'd rather just remove the warning than make -t mandatory. Ok?

@donald donald mentioned this issue Jan 10, 2024
@thomas
Copy link
Contributor Author

thomas commented Jan 10, 2024

Jepp, I'm fine with it.

@thomas thomas closed this as completed Jan 10, 2024
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants