Skip to content

Commit

Permalink
tree: Remove Description= from all units
Browse files Browse the repository at this point in the history
If a unit doesn't have a Description option, systemd will use the unit
name in messages. I think that is better, because then you don't need to
be familiar with the descriptions to mentally map, for example, "MX
mount local data filessystems" (sic!) to "mxmount.service" to get from a
log message to the unit name which you can use as an argument to
`systemctl`or `journalctl`.
  • Loading branch information
donald committed Jun 20, 2023
1 parent 94078da commit 67bade1
Show file tree
Hide file tree
Showing 24 changed files with 18 additions and 34 deletions.
2 changes: 1 addition & 1 deletion blink/blinkd.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=blinkd

ConditionHost=!wheatley.molgen.mpg.de
ConditionHost=!cerberus.molgen.mpg.de
ConditionHost=!welcome.molgen.mpg.de
Expand Down
2 changes: 1 addition & 1 deletion checktrust/getty-checktrust.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=Check Mariux64 trust for getty

Before=getty@.service

[Install]
Expand Down
2 changes: 1 addition & 1 deletion crashkernel/crashkernel.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=load crashkernel if enabled

Wants=startup-crashmemory.service
After=startup-crashmemory.service
ConditionPathExists=/node/startup-crashmemory/available
Expand Down
2 changes: 1 addition & 1 deletion logrotate/logrotate.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=Rotate log files

Documentation=man:logrotate(8) man:logrotate.conf(5)
RequiresMountsFor=/var/log
ConditionACPower=true
Expand Down
2 changes: 1 addition & 1 deletion logrotate/logrotate.timer
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=Daily rotation of log files

Documentation=man:logrotate(8) man:logrotate.conf(5)

[Timer]
Expand Down
2 changes: 1 addition & 1 deletion misc_systemd_units/admin-sshd.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=Admin sshd

After=network.target

ConditionHost=|bka.molgen.mpg.de
Expand Down
2 changes: 1 addition & 1 deletion misc_systemd_units/automount.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=Automounter

Requires=basic.target
After=basic.target

Expand Down
3 changes: 0 additions & 3 deletions misc_systemd_units/baucamhttpd.service
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[Unit]
Description=mxstartup baucamhttpd

[Service]
User=zmuser
ExecStartPre=/project/baucam/allowhosts.pl
Expand Down
2 changes: 1 addition & 1 deletion misc_systemd_units/eturnal.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=eturnal STUN/TURN server

Wants=epmd.service
After=epmd.service network.target
Documentation=https://eturnal.net/documentation/
Expand Down
3 changes: 0 additions & 3 deletions misc_systemd_units/getcams.service
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[Unit]
Description=mxstartup baucamhttpd

[Service]
User=zmuser
WorkingDirectory=/project/baucam
Expand Down
2 changes: 1 addition & 1 deletion misc_systemd_units/mxvlan.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=MX VLAN Setup

Wants=network.service
After=network.service
Before=network.target
Expand Down
2 changes: 1 addition & 1 deletion misc_systemd_units/network.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=Network Connectivity

DefaultDependencies=no

[Service]
Expand Down
2 changes: 1 addition & 1 deletion misc_systemd_units/nfsd.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=NFS Daemon

ConditionPathExists=/etc/exports
Requires=local-fs.target proc-fs-nfsd.mount var-lib-nfs-rpc_pipefs.mount
After=local-fs.target proc-fs-nfsd.mount var-lib-nfs-rpc_pipefs.mount unbound.service mxmount.service
Expand Down
2 changes: 1 addition & 1 deletion misc_systemd_units/pacbio-sshd.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=vlan.pacbio auf smrtlink sshd

After=network.target

ConditionHost=smrtlink.molgen.mpg.de
Expand Down
2 changes: 1 addition & 1 deletion misc_systemd_units/sshd.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=OpenSSH Secure Shell Service

After=syslog.target network.target

[Service]
Expand Down
2 changes: 1 addition & 1 deletion misc_systemd_units/udev-settled.target
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
# per DefaultDependencies=yes.

[Unit]
Description=udev Settled

DefaultDependencies=no
Wants=systemd-udev-settle.service
After=systemd-udev-settle.service
Expand Down
3 changes: 0 additions & 3 deletions mkmotd/motd.service
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[Unit]
Description=Make motd

[Service]
Type=oneshot
ExecStart=/usr/sbin/mkmotd.pl
Expand Down
2 changes: 1 addition & 1 deletion mxmount/mxmount.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=MX mount local data filessystems

After=mxraid.startup.service
ConditionPathExists=/etc/mxmounts

Expand Down
3 changes: 0 additions & 3 deletions mxproxmox/proxmox-backup.service
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[Unit]
Description=Proxmox Backup

[Service]
Slice=slowio.slice
ExecStart=/usr/sbin/slowio PHASE2 /usr/bin/mxproxmox local-backups
1 change: 0 additions & 1 deletion mxproxmox/proxmox-backup.timer
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
[Unit]
Description=Daily trigger of promox-backup.service

ConditionHost=!deathofrats.molgen.mpg.de

Expand Down
2 changes: 1 addition & 1 deletion mxraid/mxraid.shutdown.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=MX disassemble local software raids

After=lazy-umount-nfs.service
DefaultDependencies=false

Expand Down
2 changes: 1 addition & 1 deletion mxraid/mxraid.startup.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=MX assemble local software raids

# ConditionPathExists=/etc/mdadmconf_db

[Service]
Expand Down
2 changes: 1 addition & 1 deletion nvidiactl/nvidia.service
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
[Unit]
Description=NVIDIA Kernel Driver

Before=gdm.service

[Service]
Expand Down
3 changes: 0 additions & 3 deletions serial-log/serial-log@.service
Original file line number Diff line number Diff line change
@@ -1,6 +1,3 @@
[Unit]
Description=TTY logger

[Service]
ExecStart=/usr/libexec/serial-log %I
Type=simple
Expand Down

0 comments on commit 67bade1

Please sign in to comment.