Skip to content

Commit

Permalink
blinkd: Use system python
Browse files Browse the repository at this point in the history
This is the second part of the blinkd fix (issue #54).

PR #64 prevented the deadlock during service start.

However, currently blinkd is not starting at system boot, because
it uses `env python3` in the shebang. This will activate our default
(big, scientific) python3 which is located in /pkg and depends
on the automounter.

One solution to this problem would be to add After=automount.service
to blinkd.service. This would delay the startup of blinkd to the
point, when automounter has finished startup. However, experiments
showed, that this doesn't work. It looks like the startup
command of automount.service exists after daemon process has been
forked but before the automount paths have been mounted. So
systemd regards automount.service has started before the automount
paths are really available and services with After=automount.service
are still started to early to use them.

That aside, although /usr/bin/python3 does not to go via NFS under
normal circumstances because of the local mechanism of mxpkg, under
exceptional circumstances, this can happen (e.g. when the python3
version is updates). We don't want long-running daemons to lock
nfs mounts, so this would not be a good solution, even if made to
work.

A python3 with the blink1 package from PyPi has been added
to the system [1] and is available as
/usr/local/system/python3/bin/python3.

This python3 installation is guaranteed to be on a local
disk, so use this path in the shebang.

[1] mariux64/pkg-scripts@8e149c1
  • Loading branch information
donald committed Jan 7, 2019
1 parent e526cf4 commit 7b2c08b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions blink/blinkd.py
Original file line number Diff line number Diff line change
@@ -1,5 +1,4 @@
#!/usr/bin/env python3

#! /usr/local/system/python3/bin/python3

from blink1.blink1 import Blink1, Blink1ConnectionFailed
from multiprocessing import cpu_count
Expand Down

0 comments on commit 7b2c08b

Please sign in to comment.