mkmotd: Cache host tags

Evaluate `hostconfig` only once.
mariux64 · Jan 3, 2023 · 8209fe7 · 8209fe7
1 parent d606cee
commit 8209fe7
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/mkmotd/mkmotd.pl b/mkmotd/mkmotd.pl
@@ -9,6 +9,8 @@
 my ($os_release) = `/bin/os-release`;
 chomp($os_release);
 
+my @hostconfig = split  " ",`hostconfig`;
+
 our $TEMPLATE;
 
 if ( $os_release eq 'mariux_x86_64' || $os_release eq 'mariux_i686' ) {
@@ -41,7 +43,7 @@
 
 EOF
 
-    $TEMPLATE .= "    / to bee or not to bee /   tags: ".`hostconfig`."\n";
+    $TEMPLATE .= "    / to bee or not to bee /   tags: ".join(" ",@hostconfig)."\n";
 }
 else {
     die "$os_release : unknown os_release\n";
@@ -61,7 +63,6 @@ sub readstr {
 
 sub policy {    # policy('theinternet') --> ('zeile1,'zeile2',....)
     my ($hostname) = @_;
-    my @hostconfig=split(/ |\n/, `hostconfig`);
     open IN, '<', '/etc/mxpolicy' or return ();
     my @out;
     while (<IN>) {