Skip to content

logrotate: Don't fail when syslog not running #106

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Conversation

donald
Copy link
Collaborator

@donald donald commented Oct 17, 2019

Avoid error

logrotate[225]: dateext suffix '.2019-10'
logrotate[225]: glob pattern '.[0-9][0-9][0-9][0-9]-[0-9][0-9]'
logrotate[225]: renaming /var/log/messages to /var/log/messages.2019-10
logrotate[225]: running postrotate script
logrotate[225]: cat: /var/run/rsyslogd.pid: No such file or directory
logrotate[225]: kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... o
logrotate[225]: error: error running shared postrotate script for '/var/log/messages '
systemd[1]: logrotate.service: Main process exited, code=exited, status=1/FAILURE
systemd[1]: logrotate.service: Failed with result 'exit-code'.
systemd[1]: Failed to start Rotate log files.

@donald
Copy link
Collaborator Author

donald commented Oct 17, 2019

Hmmm. Even with || true the usage message would be emitted, which doesn't hurt but but is ugly anyway. Merge or improve. Your choice. :-)

@david
Copy link
Contributor

david commented Oct 17, 2019

What do you think, if we do on this way ?

if [ -f /var/run/rsyslogd.pid ]; then
	kill -HUP $(cat /var/run/rsyslogd.pid)
else
        send mail or start rsyslogd
fi

@donald
Copy link
Collaborator Author

donald commented Oct 17, 2019

Well, to be true, I think, logrotate should rotate logfiles, not start or monitor other daemons.

But if [ -f /var/run/rsyslogd.pid ]; then ... is fine, although my style probably would rather be something like test -f /var/run/rsyslogd.pid && ... :-)

Avoid error

    logrotate[225]: dateext suffix '.2019-10'
    logrotate[225]: glob pattern '.[0-9][0-9][0-9][0-9]-[0-9][0-9]'
    logrotate[225]: renaming /var/log/messages to /var/log/messages.2019-10
    logrotate[225]: running postrotate script
    logrotate[225]: cat: /var/run/rsyslogd.pid: No such file or directory
    logrotate[225]: kill: usage: kill [-s sigspec | -n signum | -sigspec] pid | jobspec ... o
    logrotate[225]: error: error running shared postrotate script for '/var/log/messages '
    systemd[1]: logrotate.service: Main process exited, code=exited, status=1/FAILURE
    systemd[1]: logrotate.service: Failed with result 'exit-code'.
    systemd[1]: Failed to start Rotate log files.
@david
Copy link
Contributor

david commented Oct 17, 2019

looks fine :-)

@david david merged commit 5d425a9 into master Oct 17, 2019
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants