mxgrub: Restrict access to submenu #107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pmenzel
force-pushed
the
restrict-access-to-submenu
branch
from
02fda33
to
bae643e
Compare
|
Hmmm. Now the user can switch from the previous kernel to the default kernel but not back, is that correct? User might break his workstation that way, if the default kernel doesn't support the gpu. Do we want that? |
|
When you copy set superusers in the submenu part, it will ask you 'username' and 'password' |
pmenzel
force-pushed
the
restrict-access-to-submenu
branch
from
bae643e
to
e6e9943
Compare
|
David’s workaround worked, but the GRUB developers replied to export security variable instead. Please review and accept. |
|
looks good |
|
Tested. Okay with me. But I'd remove the obsolete and the revert commits. |
Currently, it’s possible, after entering the submenu, to enter the CLI by pressing the key *c*, or to edit entries by pressing *e*. According to Vladimir, [variables related to security have to be exported][1]. [1]: https://lists.gnu.org/archive/html/grub-devel/2019-11/msg00128.html
pmenzel
force-pushed
the
restrict-access-to-submenu
branch
from
e6e9943
to
5c85b46
Compare
|
@donald, done. |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entering the submenu, a user could edit menu entries, and enter the command-line interface. Fix this by restricting the access to the submenu. As a result, users can now only manually start the default Linux kernel.