mxgrub: Include microcode updates in initramfs #11
Conversation
|
Tested with Suggestions welcome. Probably, just a check if |
mxgrub/mxgrub
Outdated
| @@ -252,7 +252,7 @@ sub cmd_update { | |||
| } | |||
|
|
|||
| sub cmd_initramfs { | |||
| sys('bash','-c','cd /project/admin/initramfs;find .|cpio -H newc -o | gzip > /boot/grub/initramfs.igz'); | |||
| sys('/project/mxtools/mxgrub/create_initramfs', 'initramfs'); | |||
There was a problem hiding this comment.
/project/mxtools ? Currenty the "mxtools" are manually spread into /usr/sbin and friends. Perhaps then "manually" should be changed perhaps mxtools should have a Makefile with install target or a bee package, but some of the tools need to be on a local disk.
There was a problem hiding this comment.
Yeah, I changed that to look for that script in the path.
mxgrub/create_initramfs
Outdated
| find .|cpio -H newc -o | gzip > "$TMPDIR"/"$INITRDNAME" | ||
|
|
||
| # | ||
| cat ucode.cpio $INITRDNAME > /boot/grub/"$INITRDNAME" |
There was a problem hiding this comment.
should /boot/grub/"INITRDNAME" be "$INITRDPATH" to include the ".igz" ?
There was a problem hiding this comment.
Indeed, I was unsure about that, if I should pass the name with or without suffix. Probably without, because it’s gzipped above in line 33.
| cd .. | ||
|
|
||
| # Clean up | ||
| rm -rf "$INITRDDIR" |
There was a problem hiding this comment.
A little bug in the lines above above or called without TMPDIR and the argument "/" or "." and the system is dead. I don't like rm -rf $SOMETHING.
pmenzel
force-pushed
the
mxgrub-include-microcode-updates-in-initramfs
branch
from
2e08507
to
0bad22b
Compare
donald
force-pushed
the
master
branch
2 times, most recently
from
91ee9fc
to
647c337
Compare
Unfortunately,
sudoalso clears the environment variable$TMPDIR, so that this needs to be fixed.