add bbu check #12
Merged
add bbu check #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donald
requested changes
Jul 11, 2017
| @@ -126,6 +126,12 @@ sub filter { | |||
| if ($proc eq 'kernel') { | |||
| /3w-9xxx.*ERROR/ and return 'DISKFAIL'; | |||
| /3w-9xxx.*Enclosure added|timed out, resetting card/ and return 'CONTROLLERFAIL'; | |||
| /3w-9xxx.*Battery is weak|not present/ and return 'BBUFAIL'; | |||
| /3w-9xxx.*Battery temperature is high|too high/ and return 'BBUTEMP'; | |||
There was a problem hiding this comment.
This matches any "too high" from the kernel. Perhaps /3w-9xxx.*Battery temperature is (high|too high)/ or /3w-9xxx.*Battery temperature is( too)? high/ ?
There was a problem hiding this comment.
Now I think it is fixed up
donald
approved these changes
Jul 11, 2017
|
I've squashed the two commits |
|
and shortened the title and prefixed it with "netlog:" |
|
ok alright |
|
@david are you ok with the the last commit "Combine 3w-9xxx and 3w-sas into a pattern" ? |
|
yes, looks better and shorter :-) |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to see bbu's they must be check be checked