Skip to content

Add desktopfiles #134

Merged
merged 13 commits into from
Nov 5, 2020
Merged

Add desktopfiles #134

merged 13 commits into from
Nov 5, 2020

Conversation

david
Copy link
Contributor

@david david commented Oct 13, 2020

add desktop files for pkg programms, so that the user can find it

Copy link
Contributor

@pmenzel pmenzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Less confusion for the MarIuX desktop users.

@@ -0,0 +1,9 @@
[Desktop Entry]
Exec=bash -c "PATH=$PATH:/usr/local/package/bin rstudio %F"
TryExec=bash -c "PATH=$PATH:/usr/local/package/bin rstudio"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn’t it installed/available on all our systems? From Desktop Entry Specification:

Path to an executable file on disk used to determine if the program is actually installed. If the path is not an absolute path, the file is looked up in the $PATH environment variable. If the file is not present or if it is not executable, the entry may be ignored (not be used in menus, for example).

@@ -0,0 +1,9 @@
[Desktop Entry]
Exec=bash -c "PATH=$PATH:/usr/local/package/bin rstudio %F"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’d be great if you added a comment, why the package path isn’t there by default, and why it works for Inkscape, and not here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rstudio is looking for R and can't find it in the PATH, because the GUI env is different from the terminal env.
'/etc/environment' != '/etc/profile'
/etc/environment set the PATH for the GUI

add '/usr/local/package/bin' to rstudio profile
@david
Copy link
Contributor Author

david commented Oct 19, 2020

I have add some other tools, which could be interesting for the user.

Maybe we can add '/usr/local/package' to XDG_DATA_DIRS, so that we can easily distinguish whether the tool comes from the package or the system.

@donald
Copy link
Collaborator

donald commented Oct 21, 2020

There already is a /usr/local/package/applications directory with a single file inkscape2.desktiop in it. I couldn't find the source for that, maybe an abandoned experiment? Anyway, I think its a good idea to put the desktop files in a separate directory and I'd suggest not /usr/local/package itself but a subdirectory (e.g. /usr/local/package/applications).

@david
Copy link
Contributor Author

david commented Oct 21, 2020

There already is a /usr/local/package/applications directory with a single file inkscape2.desktiop in it.

I think it is some old stuff from time, when inkscape was moved to package.

[...] I'd suggest not /usr/local/package itself but a subdirectory (e.g. /usr/local/package/applications).

XDG_DATA_DIRS needs subdirs with the files in it (tested on sigquit and sigill). Maybe we use /usr/local/package/desktopfiles and in it the applications folder with the desktopfiles.

@donald
Copy link
Collaborator

donald commented Oct 21, 2020

Sorry, wasn't aware of that. I'm happy with everything:

  • /usr/local/package/ in XDG DATA_DIRS and /usr/local/package/applications for the files ( your original idea, my criticism was erroneous)
  • /usr/local/package/share in XDG DATA_DIRS and /usr/local/package/share/applications for the files ( because /usr/local/package has symmetry with /usr , e.g. /usr/local/package/bin to /usr/bin.
  • /usr/local/package/desktopfiles in XDG DATA_DIRS and /usr/local/package/deskstopfiles/applications (although I think the above option is better)

@pmenzel pmenzel merged commit 58e6ae1 into master Nov 5, 2020
Sign in to join this conversation on GitHub.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants