Add bee inventory #138
Merged
Add bee inventory #138
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Register files installed from mxtools with bee so that tools like `bee query` oder bee's conflict check work. We fake a installed package mxtools-0.0-0.
|
Looks good to me. Nit: One typo in commit message: apparent. |
The explit list of destination directories to create is incomplete which becomes apparent, if installed into a empty directoy with DESTDIR=... Create any required directory implicitly.
Don't run update-desktop-database after each installed desktop file but only once after all files are installed.
After the previous commits, install_desktop_file is now reduced to the same functionality as install_data, so use this function.
donald
force-pushed
the
add-bee-inventory
branch
from
f181ca3
to
604d682
Compare
wwwutz
approved these changes
Nov 17, 2020
Closed
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed today: With this change,
make installin mxtools will register as a (fake) bee packagemxtools-0.0-0in the system so that the bee tools likebee queryandbee installs collision checks regard files from mxtools, too.Also some minor fixes for the DESTDIR=... case.