pdist: Add option --set-pdist-status #167
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donald
force-pushed
the
pdist-add-status-file
branch
from
86f0a80
to
f8d8d1d
Compare
pmenzel
reviewed
Mar 31, 2021
pdist/pdist
Outdated
|
|
||
| if ( !$fileop_noop && $force_status) { | ||
| my $t=time; | ||
| open L,'>','/.PDIST_STATUS' or die "/.PDIST_STATUS: $!\n"; |
There was a problem hiding this comment.
Can we write it lowercase .pdist_status? At least for me, that’s easier to type.
There was a problem hiding this comment.
Yes, I mirrored what pmirror does ( ".PMIRROR_STATUS" ) but I don't really care.
pdist/pdist
Outdated
| @@ -1186,6 +1195,7 @@ usage: $0 cmd [options] | |||
| --fileop_debug # log all file operations | |||
| --[no]delete # do or do not clean up additional files on client. | |||
| # default is delete unless --files is used | |||
| --force_status # force creation of /.PDIST_STATUS on target | |||
There was a problem hiding this comment.
- Is there a pattern, when to use - and _? I’d prefer
--force-status. - Why force and not create for example, or
--set-pdist-status.
There was a problem hiding this comment.
You're right. Again, I've copy-pasted from pmirror. I change that into --set-pdist-status
donald
force-pushed
the
pdist-add-status-file
branch
2 times, most recently
from
fdae58b
to
2720ef3
Compare
Add option --set-pdist-status. This option make the client write a status file /.pdist_status when everything completed successfully. It is supposed to be used only during full dists from the distmaster. The idea is that health check scripts can look at the status file and the embededed time tag to find out when a system was successfully updated and generate an alarm if this is to long in the past.
donald
force-pushed
the
pdist-add-status-file
branch
from
2720ef3
to
cfe4db8
Compare
donald
changed the title
pmenzel
approved these changes
Mar 31, 2021
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add option --set-pdist-status. This option make the client write a status
file /.pdist_status when everything completed successfully. It is
supposed to be used only during full dists from the distmaster.
The idea is that health check scripts can look at the status file and
the embededed time tag to find out when a system was successfully
updated generate an alarm if this is to long in the past.