nvidiactl: Load drm modules #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are going to change the kernel DRM modules from static to dynamic. nvidia_drm.ko requires drm and drm_kms_helper. If theses are dynamic modules, probe them before we load the nvida modules.
pmenzel
reviewed
Dec 15, 2017
| @@ -48,6 +48,10 @@ nvver=$(readlink ${leglink}) | |||
|
|
|||
| rm -f /node/usr_share_mxgfx | |||
| ln -sf /usr/share/nvidia/${nvver} /node/usr_share_mxgfx | |||
|
|
|||
| test -e /lib/modules/$kver/kernel/drivers/gpu/drm/drm.ko && modprobe drm | |||
There was a problem hiding this comment.
Passing the force switch --force to modprobe should also work, shouldn’t work. But it’s not important.
There was a problem hiding this comment.
But the man page says, "so using this option is dangerous unless you know what you are doing". So obviously this is not an option to us 🤣
There was a problem hiding this comment.
I just read up to dangerous and thought that’s good. ;-)
|
Looks good to me. |
|
Did I miss something important about the --force switch ? |
|
On 12/15/17 13:43, Thomas Kreitler wrote:
Did I miss something important about the --force switch?
Only that @donald thinks we don’t know what we are doing.
|
|
grin |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are going to change the kernel DRM modules from static to dynamic.
nvidia_drm.ko requires drm and drm_kms_helper. If theses are dynamic
modules, probe them before we load the nvidia modules.