hostconfig: Use make_path to create possible non-existing directory /node

[Paul Menzel (pmenzel)]

No description provided.

[Donald Buczek (donald)]

Did you test that? I think, make_path is from some module.
Sigh, this node thing is an ugly, obsolete hack. I hoped to get rid of it.
Strange design of systemd to fail on an "exists"-test if a parent doesn't exist. I'd say, the answer "no" would be more sensible. Maybe I create an issue for that, if that hasn't been on the table yet.

[Paul Menzel (pmenzel)]

Did you test that? I think, make_path is from some module.

No, I didn’t. I definitely tagged to need more testing. No idea, why GitHub didn’t add it.

Sigh, this node thing is an ugly, obsolete hack. I hoped to get rid of it.

Sounds good.

Strange design of systemd to fail on an "exists"-test if a parent doesn't exist. I'd say, the answer "no" would be more sensible. Maybe I create an issue for that, if that hasn't been on the table yet.

Sorry, what do you mean. hostconfig --populate-node fails.

hostconfig[1297907]: /node/tags: No such file or directory
systemd[1]: startup-tags.service: Main process exited, code=exited, status=2/INVALIDARGUMENT

[Donald Buczek (donald)]

Sorry, what do you mean. hostconfig --populate-node fails.

My bad. I was missreading that from a mobile.

btw: system 'mkdir', '-p', $DIR and exit 1; would also be an option and would avoid to use an addition perl module.

[Peter Marquardt (wwwutz)]

sub mkdirp {
  my $d = shift;
  my $dtc = '';
  foreach my $sd ( split(/\//,$d) ) {
     ($sd eq '') and $sd = '/';
     $dtc .= $sd;
     if ( ! -d $dtc ) {
         mkdir($dtc) or return $!;
     }
     $dtc .= '/';
  }
  return 1;
}

[Donald Buczek (donald)]

Peter Marquardt (@wwwutz): return $! .vs. return 1. If you return errno value for failure, maybe return 0 for success.

[Peter Marquardt (wwwutz)]

zero, false, $? ... 8-) it's just an example, feel free to change. At least it doesn't load shared libs 8-))))
and it does not want to mkdir -p anything else than a path. not user-input-save. but enough for mkdirp('/node/foobar').

will certainly fail on ../../../././../\rm, -rf`\ /\\ \ ` " \'''``\ \0\0\

hehe... but... hey.. we're talking about mkdir('/node/foobar') in hostconfig ... not netcat -l -p 80 | sudo

[Donald Buczek (donald)]

../../../././../\rm, -rf\ /\\ \ " '''``\ \0\0\

Hmmm, that should actually work. If \0 refers to the two-character sequence backslash and digit zero no surprise. If, on the other hand, '\0' refers to a character encoded with as a binary zero byte, mkdir(2) would try to create a directory ../../../././../\rm, -rf\ /\ \ " \'''``\ which might or might not be what was intended. And if backslash+character was used to indicate a special single character here, the meaning of the lonely backslash character at the end would need to be defined.

How about mkdir "\e[2J" ? If you cd into that directory, you will always have a nicely cleaned up screen (if your shell prompt includes the cwd). Do Terminal emulators nowadays still allow to redefined keys via escape sequences? Create a directory "This_is_a_vary_long_directory_dont_look_into_it" concatenated with the escape sequence to redefine the enter key to rm -rf / and wait until a nosy and lazy root uses cd This<TAB> to get into it :-)