Mxvmem maintenance #285
Merged
Mxvmem maintenance #285
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From the context the tool fits in forensics. Also it was accepted to have a python script therein.
Reading logfiles containing 'strange' bytes, would yield errors like: "UnicodeDecodeError: 'utf-8' codec can't decode byte 0xb3 in position 3221: invalid start byte" Either switch to binary input, or escape the characters in question. Here the latter was choosen.
donald
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
nits:
- Commits 1 and 2 could be one because its a single logical operation and it doesn't work when only half is done
- Commit messages could start uppercase
Was about to say, that backslashreplace was not required in ProcBuffer, because the non-ascii and non-utf8 characters came from /proc/PID/fd, which only exists in the forensic logfile, but, yes, there is "Name:" in /proc/PID/status.
buczek@theinternet:~/x$ head -2 /proc/$$/status
Name: äöü
Umask: 0002
:-)
|
Also I do not know if someone uses |
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.