netlog: Remove daemon features #300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We now run the netlog daemon as a systemd service. The features to demonize, redirect logging, restart and kill previous daemons are all not needed. Additionally, the restart is buggy, because Donald::Tools::kill_previous_server doesn't kill the parent - assuming this is an rc.d script. However, in `--foregound` mode, the previous daemon is in fact the parent. - Remove unused features and leave job control and logging to systemd. - Log into journal instead of into syslog. - Remove "Description=" from the unit, because its easier to identify things, when the name used in messages is the same as the unit name and the unit file name.
pmenzel
reviewed
Jan 20, 2023
| Requires=network.target | ||
| After=network.target | ||
|
|
||
| [Service] | ||
| ExecStart=/usr/sbin/netlog --daemon --foreground --kill --syslog /var/log/messages /var/log/mail.log | ||
| ExecStart=/usr/sbin/netlog --daemon /var/log/messages /var/log/mail.log |
There was a problem hiding this comment.
Isn’t the --daemon not very systemd idiomatic(?), that means, it prefers programs that do not daemonize?
There was a problem hiding this comment.
Year right. There are two operating modes: What would be better?
netlog test files...
netlog run files...
?
There was a problem hiding this comment.
Maybe "watch" instead of run, because it watches the named files. Or "service", because it runs forever waiting for external events (data appended top these files). "service" seems to be better when applied to clusterd, which also has "--daemon" at the moment. clusterd loops forever waiting for external events over the network. idk.
There was a problem hiding this comment.
I like watch, but don’t have a strong opinion.
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now run the netlog daemon as a systemd service. The features to
demonize, redirect logging, restart and kill previous daemons are all
not needed. Additionally, the restart is buggy, because
Donald::Tools::kill_previous_server doesn't kill the parent - assuming
this is an rc.d script. However, in
--foregoundmode, the previousdaemon is in fact the parent.
things, when the name used in messages is the same as the unit name
and the unit file name.
Fixes #299
I love more "-" than "+" :-)
netlog/netlog | 43 +------------------------------------------
netlog/netlog.service | 5 +----