mxmount: Avoid mounting /amd/host/0 a second time #307
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Paul Menzel (pmenzel)
approved these changes
Feb 6, 2023
Contributor
Paul Menzel (pmenzel)
left a comment
Paul Menzel (pmenzel)
left a comment
There was a problem hiding this comment.
… path is compared to
/amd/SHORTHOST/$hostname/0instead of/amd/SHORTHOST/$hostname/0.
The mentioned paths look identical.
When booting from a usb stick, `/amd/mxonastick/0` is explicitly mounted with a label other than data0. However, if there is an existing "data0" filesystem (e.g. on the internal hdd), this is mounted on top of it. There is code to avoid that in mxmounts, but it doesn't work because `DEFAULT_MOUNT_PREFIX` contains `/amd/SHORTHOST` and so the path is compared to `/amd/SHORTHOST/$hostname/0` instead of `/amd/$hostname/0`. Fixes 6c9441e ("fix data0 destination overmount")
Donald Buczek (donald)
force-pushed
the
fix-mxmount-overmount
branch
from
e49eee0 to
2ef44b5
Compare
Sign in
to join this conversation on GitHub.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import fix from unmerged PR mariux64/mxmount#1 in mxmounts previous repository.
When booting from a usb stick,
/amd/mxonastick/0is explicitly mountedwith a label other than data0. However, if there is an existing "data0"
filesystem (e.g. on the internal hdd), this is mounted on top of it.
There is code to avoid that in mxmounts, but it doesn't work because
DEFAULT_MOUNT_PREFIXcontains/amd/SHORTHOSTand so the path iscompared to
/amd/SHORTHOST/$hostname/0instead of/amd/$hostname/0.Fixes 6c9441e ("fix data0 destination
overmount")