Clean up startup #328
Merged
Clean up startup #328
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donald
force-pushed
the
cleanup-startup-tags
branch
from
3a57476
to
c5310f1
Compare
pmenzel
approved these changes
Jun 19, 2023
donald
force-pushed
the
cleanup-startup-tags
branch
4 times, most recently
from
f3928ad
to
1a7994e
Compare
donald
force-pushed
the
cleanup-startup-tags
branch
from
1959991
to
66d953f
Compare
|
Install: |
donald
force-pushed
the
cleanup-startup-tags
branch
3 times, most recently
from
cb882c2
to
976a745
Compare
|
Because of the changes to to mxraid/mxmount, we should test startup and shutdown on server with raid. |
donald
force-pushed
the
cleanup-startup-tags
branch
from
976a745
to
9e73b30
Compare
|
I think we are good to go. Any comments anyone? |
|
Awesome (and tedious) work. Very nice. If you could update the merge/pull request description, that’d be great. Also, what you found out about the i915 and Nvidia (even nouveau?) console issue, would be nice to know. Maybe also share the new |
|
Will poke around a little more :-) |
donald
force-pushed
the
cleanup-startup-tags
branch
from
9e73b30
to
8ccf9d3
Compare
donald
force-pushed
the
cleanup-startup-tags
branch
from
8ccf9d3
to
70ba0c0
Compare
|
Import mxstartup? |
|
btw: automount startup ist slow because of the map translation amd->automount in Maybe we can just skip the step. The |
donald
force-pushed
the
cleanup-startup-tags
branch
from
70ba0c0
to
64cd374
Compare
donald
added a commit
to mariux64/bee-files
that referenced
this pull request
Jul 4, 2023
PR mariux64/mxtools#328 imports mxstartup into the mxtools repository. Remove bee-based installation.
startup-tags.service has been made a dependency of sysinit.target. As all services depend on sysinit.target by default, we no longer need an explicit dependency on startup-targs.service in the individual services.
Currently, automount.service races with mxstartup.service. mxstartup itself and also the services it starts, expect paths like /pkg to be available. So make automount namespace part of basic.target. Normal Services order after basic.target by default.
It is not possible to use template units with directives, so
Before=getty@.service
does not work.
There is a getty-pre.target unit which can be requested by services,
which want to be ordered before getty. Use that instead.
Although, WantedBy=getty@.service does work, this is strictly not
correct, because we want this service to run indepdendent from getty,
for example, to set the tag for lightdm. Change to
WantedBy=multi-user.target.
Add a service which waits (max 15 seconds) for the network to be
available. We define 'available' as the ability to ping our default
router by its name, which implies dns is working.
Service units, which really need network to start, should add
After=network-online.target
Wants=network-online.target
Allow inet free binds (bind to any ip address) so that services which bind to specific ip addresses (e.g. $MX_IPADDR) don't need to wait for network setup. This simplifies our startup, because we can avoid to pull network-online.target or order units after network.service just to to be able to listen to a specific address. Note, that we still need network to resolve names to addresses.
See [1]. The network service providers (network.service, mxvlan.service, unbound.service) are pulled from multi-user.target (not from network.target). network.service pulls network.target so that other services might use "After=network.target" (only for shutdown order). network.service, which has DefaultDependencies=no, needs to order iteslf behind sysinit.target, so that the network devices are available. [1]: https://systemd.io/NETWORK_ONLINE/
Units, which want to use the console before getty is started, can order themself before getty-pre.target. Use the same target before loading a graphics driver which disrupts the screen.
After we disabled autoloading of i915 to avoid loosing the startup console on an nvidia card, we need to load it manually. Add service to do so.
There is a race when other services want to use local amd paths. All services order behind basic.target per default, so move mxraid and mxmount before it. Also make mxraid.startup.service and mxraid.shutdown.service into one but temporarily keep mxraid.shutdown.service for running systems. Use systemd-udev-settle.service instead of our udev-settled.target, which can be removed in a later commit.
After basic.target, local automount paths should work. Also, we can start without network connectivity. Remove obsolete dependencies.
We might start up a service which requires network connectivity, so wait for it.
On shutdown, automount tries to unmount all remaining mount points. This might include remote mountpoints. Order after network.target, so that automount gets stopped before network.target. See [1]. [1]: https://www.freedesktop.org/wiki/Software/systemd/NetworkTarget/
automount.service, which now is before basic.target, ist rather slow to start. nfsd.service doesn't need to wait for it, because we are not going to export automount paths.
This is no longer needed. Services can wait for systemd-udev.settle.service. Services behind sysinit.target already do that.
Import files from b51f29e5 ("Merge pull request #10 from
mariux64/fix-su-option") of github.molgen.mpg.de:mariux64/mxstartup.git
into repository.
It is just cumbersome to have these n a seperate repository with
releases and bee installation.
The mxstartup bee package should be deinstalled if this is merged.
This reverts commit 7d5d66c.
Only wait for network online, because /etc/,xstartups uses hostnames which need to be resolved and services started by it might fail when they don't have network. Remove other dependencies are already resolved by DefaultDependencies. Also remove Desription for easier debugging.
Using the default perl triggers an unwanted automounter call during startup.
Avoid the time consuming step to regenerate automount maps from the amd maps. It dowsn't make much sense, because the amd maps should be as good as the amd maps.
Import lightdm.service from bee packge ligthdm-1.30.0-3.x86_64 into this repository.
Use alias for the order. This also removes the reference to the non-existing gdm.service.
Remove startup-tags condition, because we only have lightdm now. Remove dependencies on startup-tags.service as well, which would not be needed even if we used the tags. Also, remove After= dependency to nvidia.service, because this is now handled by nvidia.service with a Before=display-manager.service dependency.
donald
force-pushed
the
cleanup-startup-tags
branch
from
64cd374
to
f1476fa
Compare
Merged
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comb through startup logic