install.sh: Fix bee registery of /etc/files #343
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Which is better ? shopt -s lastpipe
(cd etc ; find * -type f) | while read -r path; do
if [[ -x etc/$path ]]; then
install_exec etc/$path "$DESTDIR$sysconfdir/$path"
else
install_data etc/$path "$DESTDIR$sysconfdir/$path"
fi
doneor while read -r path; do
if [[ -x etc/$path ]]; then
install_exec etc/$path "$DESTDIR$sysconfdir/$path"
else
install_data etc/$path "$DESTDIR$sysconfdir/$path"
fi
done < <(cd etc ; find * -type f) |
|
I like the second version not using |
|
whereas I don't like the |
Ok, I take that one then.
Correct, I'll fix it. |
The function install_etc_files contains a bug which causes the files in etc not to be probably registered in the crafted bee index of the "mxtools-0.0-0" package. The reason is, that the functions install_exe and install_data are called from the last command of a pipeline. By default, this is executed in a subshell, so the implicit modification of the global variable INSTALLED_FILES is not seen by main process, which later uses it to generate the index. Make the loop run in the main shell process.
Although the local `etc` directory should contain only sane files, stick to good habit and avoid `find *`, which misinterpretes filenames starting with `-`. Also add quotes to avoid missinterpretation of filenames with whitespace.
donald
force-pushed
the
fix-etc-bee-index
branch
from
e2952e9
to
af9dd1c
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function install_etc_files contains a bug which causes the files in etc not to be probably registered in the crafted bee index of the "mxtools-0.0-0" package.
The reason is, that the functions install_exe and install_data are called from the last command of a pipeline. By default, this is executed in a subshell, so the implicit modification of the global variable INSTALLED_FILES is not seen by main process, which later uses it to generate the index.
Use the "lastpipe" shell option, which makes the last command of a pipeline run in the main shell process.