Skip to content
Jump to bottom

Fight zombies! #437

Merged
merged 5 commits into from
Jan 29, 2025
Merged

Fight zombies! #437

merged 5 commits into from
Jan 29, 2025

Commits on Jan 29, 2025

  1. clusterd: Reap children 

    Currently we leave zombies after udp_rx_push2() and possibly in other
places.

Reap children in the main loop.
    @donald
    donald committed Jan 29, 2025
    Configuration menu
    Copy the full SHA
    4439dad View commit details
    Browse the repository at this point in the history

  2. clusterd: close STDIN in daemon 

    When in daemon mode, close stdin right away. This avoids the need to
close stdin in various places after a fork.
    @donald
    donald committed Jan 29, 2025
    Configuration menu
    Copy the full SHA
    afb4946 View commit details
    Browse the repository at this point in the history

  3. clusters: Do not return ignored values from clp_rx_ functions

    @donald
    donald committed Jan 29, 2025
    Configuration menu
    Copy the full SHA
    3e1cff5 View commit details
    Browse the repository at this point in the history

  4. clusterd: Wait for specific pids 

    Now that we accept random children to exist and exit at any time, use
waitpid() instead of wait() when we wait for a specific child somewhere
else in the code.

This change revealed an error in udp_rx_exec2() which might have
executed /sbin/make-automaps redundantly. Fix that. This is not tested
or analyzed very much, but udp_rx_exec2() is obsolete and should go away
soon anyway.
    @donald
    donald committed Jan 29, 2025
    Configuration menu
    Copy the full SHA
    1264eb2 View commit details
    Browse the repository at this point in the history

  5. clusterd: Remove double-forks 

    In two places we used double forks, probably so that we don't need to
reap. Now children are reaped in the main loop, so remove the extra
forks.
    @donald
    donald committed Jan 29, 2025
    Configuration menu
    Copy the full SHA
    9a2eaf9 View commit details
    Browse the repository at this point in the history