Improve clusterd security.2 #438
Merged
Commits on Jan 29, 2025
-
Currently we leave zombies after udp_rx_push2() and possibly in other places. Reap children in the main loop.
-
clusterd: close STDIN in daemon
When in daemon mode, close stdin right away. This avoids the need to close stdin in various places after a fork.
-
clusterd: Wait for specific pids
Now that we accept random children to exist and exit at any time, use waitpid() instead of wait() when we wait for a specific child somewhere else in the code. This change revealed an error in udp_rx_exec2() which might have executed /sbin/make-automaps redundantly. Fix that. This is not tested or analyzed very much, but udp_rx_exec2() is obsolete and should go away soon anyway.
-
In two places we used double forks, probably so that we don't need to reap. Now children are reaped in the main loop, so remove the extra forks.
-
-
-
-
-
-
-
clusterd: Improve usage string
Improve usage string from really ugly to ugly, you are not a designer.
-
clusterd: Remove push_file() and push_amd_tar()
Remove the functions which implemented the obsolete commands `--push` and `--push-amd-tar`.
-
-
-
-
-
-
-
-
-
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.