Skip to content
Jump to bottom

Mxraid fixups #45

Merged
merged 3 commits into from
May 14, 2018
Merged

Mxraid fixups #45

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
47bf25c
mxraid_assemble: Always perform system command
thomas May 11, 2018
4a8a53c
mxraid_assemble: Fix print command
thomas May 11, 2018
550576b
mxraid_assemble: Improve disk listing
thomas May 11, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions mxraid/mxraid_assemble
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,7 +120,7 @@ if ($opts{l}) {
print "\n";
}
if ($VERBOSE >= 2) {
print "Disks not part of a SW-RAID:\n";
print "Disks not part of a configured SW-RAID:\n";
for my $rec (@{$hd->non_raid_disks()}) {
printf " %5s %-16s '%s'\n", @$rec;
}
Expand Down Expand Up @@ -297,8 +297,8 @@ sub create_mdadm_configs {
if ($do_assemble) {
my @args = ('mdadm', '-A', '/dev/md'.$dev_no, '-c', $conf_fn);
push @args, split m/\s+/, $MDADM_ASSEMBLE_OPTIONS if $MDADM_ASSEMBLE_OPTIONS;
warn printf "# NOTE: $rlabel, running '%s'\n", join(' ', @args) if $VERBOSE >= 2;
system (@args) == 0 or warn "# Error system @args failed: $?" if $VERBOSE >= 1;
warn sprintf "# NOTE: $rlabel, running '%s'\n", join(' ', @args) if $VERBOSE >= 2;
system (@args) == 0 or warn "# Error system @args failed: $?"; # serious, always warn
} else {
printf "mdadm -A /dev/md%d -c %s\n", $dev_no, $conf_fn;
}
Expand Down