Fix mxrouter del vlan #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
donald
force-pushed
the
fix-mxrouter-del-vlan
branch
from
28a99f9
to
b0d2f04
Compare
|
the general login → the general logic |
When a vlan interface definition is removed from the configuration, currently the code attempts to remove the actual vlan interface twice: once by the general logic ($have_if, $want_if -> unconfigure_if()) and once by the special logic ($have_vlan, $want_vlan -> unconfigure_vlan()). Remove the later.
donald
force-pushed
the
fix-mxrouter-del-vlan
branch
from
b0d2f04
to
3c22ccd
Compare
Sign in
to join this conversation on GitHub.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.