install.sh: Never let install_symlink descend into its link name
#581
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'ln -sfv target link' treats 'link' as a directory to create the link *in*
whenever it is a directory, or a symbolic link to one. install_symlink()
therefore silently installs to the wrong place as soon as the link name is
already occupied by a directory:
$ mkdir -p a/icd.d
$ ln -sfv /usr/share/mxgfx/vulkan/icd.d a/icd.d
'a/icd.d/icd.d' -> '/usr/share/mxgfx/vulkan/icd.d'
That is the case for any /etc directory a tool created at runtime before
mxtools started shipping it as a link, and the readlink() guard above does
not catch it – readlink() of a directory is empty, so it always differs
from the wanted target.
'--no-dereference' is not enough, it only covers a symbolic link to a
directory, not a real one. Use '--no-target-directory', which makes both
cases behave:
$ ln -sfTv /usr/share/mxgfx/vulkan/icd.d a/icd.d
ln: a/icd.d: cannot overwrite directory
Fail the install rather than continue, as the file is registered in the bee
CONTENT either way, and a wrongly placed link would be recorded as if it
had been installed.
Assisted-by: Claude Opus 5 <noreply@anthropic.com>
donald
approved these changes
Sep 7, 2026
Sign in
to join this conversation on GitHub.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.