hostconfig: Do not interpolate $_ into the term-validation regex
#586
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The character class in the term check is written as [a-z0-9$_-],
intending to allow letters, digits, underscore and dash in tag names.
Perl interpolates $_ (the token currently being examined) into the
class, though. As a result the accepted characters depend on the token
itself, and any term containing a dash aborts the whole evaluation:
$ hostconfig 'nvidia-no-gsp'
Invalid [] range "t-d" in regex; marked by <-- HERE in
m/^[a-z][a-z0-9nvidia-no-gsp <-- HERE -]*$/ at /usr/sbin/hostconfig line 43.
Drop the stray $ so the class is literal and dashed tag names work.
Assisted-by: Claude Fable 5 <noreply@anthropic.com>
Fixes: 74d8a45 ("Add hostconfig")
donald
reviewed
Sep 18, 2026
| @@ -40,7 +40,7 @@ sub evalue_expression { | |||
| $options{'debug'} and warn join(' ',map("'$_'",@l)),"\n"; | |||
| for (@l) { | |||
| s/\s*(.+?)\s*/$1/; | |||
| if (/^[a-z][a-z0-9$_-]*$/i) { | |||
| if (/^[a-z][a-z0-9_-]*$/i) { | |||
Collaborator
There was a problem hiding this comment.
Why not /^[a-z][a-z0-9\$_-]*$/i if intention "to allow letters, digits, underscore and dash in tag names" is assumed? NIT, just wondering....
Sign in
to join this conversation on GitHub.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.